-
-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Add Support for React 19 Compatibility in Plasmo #1141
Comments
@louisgv Any update about it? |
Having this issue too. Specifically the error I get is "No supported UI library found". In case anyone else is searching the repo for this message |
For anyone encountering this issue, here's the root cause: Plasmo does not currently support React v19. The code responsible for this version check can be found here: Manifest Factory UI Library if (!(await isAccessible(staticPath))) {
throw new Error(uiLibraryError);
} |
We really want this. It's causing issues with our pnpm monorepo where we have a nextjs app requiring react19, but adding our browser extension to the monorepo (and demanding react18, and its relevant @types/react), its causing type errors on our nextjs project(?) |
Agree. Need support React 19. |
I've made a PR which should hopefully add support for React 19 #1167 |
Merged. Could you try out |
How do you envision this feature/change to look/work like?
Plasmo should work with React 19 without blocking updates due to version checks. Right now, the framework checks for a specific React version and fails if React 19 is used. Additionally, there is no folder or template similar to cli/plasmo/templates/static/react18, which would make it easier to support the new version.
The idea is to remove or loosen the version checks and add a React 19-specific folder/template if needed.
What is the purpose of this change/feature? Why?
The lack of support for React 19 prevents developers from upgrading to the latest React version. This blocks access to new features, better performance, and long-term updates, making projects feel stuck on older versions.
Adding support would let developers upgrade without worries and keep their projects modern.
(OPTIONAL) Example implementations
(OPTIONAL) Contribution
Verify canary release
plasmo
canary releaseCode of Conduct
The text was updated successfully, but these errors were encountered: