Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to navigate to plasticscm.com/download when no valid cm.exe #12

Open
SergioLuis opened this issue Dec 18, 2019 · 1 comment
Open

Allow to navigate to plasticscm.com/download when no valid cm.exe #12

SergioLuis opened this issue Dec 18, 2019 · 1 comment
Labels
good first issue Good for newcomers

Comments

@SergioLuis
Copy link
Contributor

SergioLuis commented Dec 18, 2019 •
edited
Loading

When some Visual Studio Code extensions such as the C# or Java ones cannot detect the additional software they need (such as a valid MSBuild or Java JDK setups), they show an error dialog.

These error dialogs have buttons that open a web browser with the page where the user can download the missing toolchain.

Implement this for the Plastic SCM extension.

The button should lead to https://plasticscm.com/download when there is no valid cm.exe in the PATH.

Additionally, it would be extremely nice to be able to force a given cm through configuration file (for example, because we installed Plastic SCM using the ZIP installers, so the client directory is not in the user's PATH) - this dialog should have another button that leads directly to said configuration file / key.
@SergioLuis SergioLuis changed the title Allow to navigate to plasticscm.com/download when there's no valid cm.exe Allow to navigate to plasticscm.com/download when no valid cm.exe Dec 18, 2019
@SergioLuis SergioLuis added the good first issue Good for newcomers label Dec 18, 2019
@mig42
Copy link
Contributor

mig42 commented Dec 18, 2019

That addition links this to #13, which is good.

@SergioLuis SergioLuis mentioned this issue Dec 19, 2019
Closed
@SergioLuis SergioLuis mentioned this issue Dec 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mig42 @SergioLuis