-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In lining CSS breaks styles. #295
Comments
Thanks |
@JojokCreator I tried running it with: npm install ; npm run build ; npm run preview and styles are working correctly and they're inlined: Am I missing something? |
Signed-off-by: Nikola Hristov <[email protected]>
Managed to reproduce. I think this is due to
import { defineConfig } from 'astro/config';
// https://astro.build/config
export default defineConfig({
integrations: [
(await import('@playform/inline')).default({
Critters: {
reduceInlineStyles: false,
},
}),
],
}); should be working fine: Somehow these styles get omitted because there's no active class on the component yet.
Will be disabled by default in the latest version. |
Perfect thank you.
…________________________________
From: Nikola Hristov ***@***.***>
Sent: Wednesday, July 24, 2024 6:03:52 PM
To: PlayForm/Inline ***@***.***>
Cc: J_Klakus ***@***.***>; Mention ***@***.***>
Subject: Re: [PlayForm/Inline] In lining CSS breaks styles. (Issue #295)
Managed to reproduce. I think this is due to reduceInlineStyles https://github.com/GoogleChromeLabs/critters#properties
import { defineConfig } from 'astro/config';
// https://astro.build/config
export default defineConfig({
integrations: [
(await ***@***.***/inline')).default({
Critters: {
reduceInlineStyles: false,
},
}),
],
});
should be working fine:
image.png (view on web)<https://github.com/user-attachments/assets/a16ccbbb-a328-4fd3-8279-af3e65f4f74d>
Somehow these styles get omitted because there's no active class on the component yet.
image.png (view on web)<https://github.com/user-attachments/assets/531182ab-f0a2-4ff7-a0ce-564bbbe12560>
reduceInlineStyles
Will be disabled by default in the latest version.
—
Reply to this email directly, view it on GitHub<#295 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AXPIZCNWZPYBLEWAOJR3CL3ZN6CZRAVCNFSM6AAAAABIVUUQY2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBXGYYTOOJSGM>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Hi, trying to use this amazing tool in a project. It works well for the most part but I have a few pages with embedded videos using https://astro-embed.netlify.app/components/youtube/ when I build and deploy the project the styles on the videos seem to get broken.
https://stackblitz.com/edit/withastro-astro-wsnvzt <-- example here.
To reproduce run
npm run dev
= styles are okay.npm run preview
(with the inlined css) = styles are broken.The text was updated successfully, but these errors were encountered: