Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PBool has no PTryFrom instance #612

Open
MangoIV opened this issue Feb 17, 2023 · 3 comments
Open

PBool has no PTryFrom instance #612

MangoIV opened this issue Feb 17, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@MangoIV
Copy link
Collaborator

MangoIV commented Feb 17, 2023

It seems like a PTryFrom instance for PBools is missing; however, this seems a bit more involved because you cannot trivially import PData or PAsData into either of the modules Plutarch.Bool or Plutarch.TryFrom
@L-as
Copy link
Member

L-as commented Feb 18, 2023

You could put the instance in the module that defines PData possibly

@MangoIV MangoIV changed the title PBool has not PTryFrom instance PBool has no PTryFrom instance Feb 18, 2023
@MangoIV
Copy link
Collaborator Author

MangoIV commented Feb 18, 2023

You could put the instance in the module that defines PData possibly

that will not make it an orphan?

@MangoIV
Copy link
Collaborator Author

MangoIV commented Feb 18, 2023

We can't even declare a PTryFrom instance because PInner PBool = PBool

@SeungheonOh SeungheonOh added the bug Something isn't working label Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@L-as @SeungheonOh @MangoIV