Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: selectable language to send or receive message for trade companion #326

Open
archanfel777 opened this issue Apr 16, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@archanfel777
Copy link

archanfel777 commented Apr 16, 2023

🚀 feature request

Is your feature request related to a problem? Please describe.
Hello
I am using the English client of GGG headquarters, but the game language is Korean.

The messages sent and received during transactions are in Korean, but the trade companion does not work because it does not recognize them.
However, it works fine when sending or receiving messages in English.

It is presumed that only English messages are recognized because PoE-Overlay's webpage was logged in in English, the PoE client is in English, or my PoE account belongs to GGG, which is based on English.

Actually, since the transaction message is the same as the in game language with a high probability, it is reasonable to determine that the language detected for the trade companion to operate is the same as the Game settings - Language(in game language) set in PoE-Overlay.

If possible, could you please reflect the changes regarding this?
Thank you for always providing great features.

I've checked the notification code and realized that it was checking all language texts and that the Korean texts have changed since 3.21.
I tried to make PR by directly modifying the Korean text, but it failed with an unknown error
So the Korean field that needs to be modified in trade-regexes.json is posted here.
Hopefully this text fix will be merged.

joinedArea.Korean : ": (?.*?) 님이 지역에 들어왔습니다\.?"

leftArea.Korean : ": (?.*?) 님이 지역에서 나갔습니다\.?"

tradeItemPrice.Korean : "^안녕하세요, (?\d*([.|,]\d*)?) (?.)\(으\)로 올려놓은 (?.) 리그의 (?.)\(을\)를 구매하고 싶습니다 \(보관함 탭 \"(?.)\", 위치: 왼쪽 (?\d*), 상단 (?\d*)\)(?.*)?"

tradeItemNoPrice.Korean : "^안녕하세요, (?.) 리그의 (?.)\(을\)를 구매하고 싶습니다 \(보관함 탭 \"(?.)\", 위치: 왼쪽 (?\d), 상단 (?\d*)\)(?.*)?"

tradeBulk.Korean : "^안녕하세요, (?.) 리그의 (?\d) (?.)\(을\)를 (?\d([.|,]\d*)?) (?.)\(으\)로 구매하고 싶습니다\.?(?.)?"

Thx for your support.

Describe the solution you'd like
Making the trade companion's action trigger message language the same as the PoE-Overlay's Game settings - Language

Describe alternatives you've considered

Additional context

@archanfel777 archanfel777 added the enhancement New feature or request label Apr 16, 2023
@archanfel777 archanfel777 changed the title Suggestion: selectable language to send or receive for trade companion Suggestion: selectable language to send or receive message for trade companion Apr 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant