fix(localization): adding in some missed strings (#442)

Author: bassrock

PocketKit/Sources/PocketKit/MyList/ItemsList/ItemsListItemPresenter.swift

@@ -96,6 +96,6 @@ class ItemsListItemPresenter {
     private var timeToRead: String? {
         item.timeToRead
             .flatMap { $0 > 0 ? $0 : nil }
-            .flatMap { "\($0) min" }
+            .flatMap { L10n.Item.List.min($0) }
     }
 }

PocketKit/Sources/PocketKit/MyList/SearchItemsList/SearchView.swift

@@ -61,7 +61,7 @@ struct ResultsView: View {
         .accessibilityIdentifier("search-results")
         .banner(data: viewModel.bannerData, show: $viewModel.showBanner)
         .alert(isPresented: $showingAlert) {
-            Alert(title: Text("You must have an internet connection to view this item."), dismissButton: .default(Text("OK")))
+            Alert(title: Text(L10n.Search.Error.View.needsInternet), dismissButton: .default(Text("OK")))
         }
     }
 }
@@ -84,7 +84,7 @@ struct RecentSearchView: View {
 
     var body: some View {
         List {
-            Section(header: Text("Recent Searches").style(.search.header)) {
+            Section(header: Text(L10n.Search.recent).style(.search.header)) {
                 ForEach(recentSearches.reversed(), id: \.self) { recentSearch in
                     HStack {
                         Text(recentSearch)

PocketKit/Sources/PocketKit/Resources/en.lproj/Localizable.strings

@@ -40,6 +40,7 @@
 "Unfavorite" = "Unfavorite";
 "Move to Saves" = "Move to Saves";
 "Add Tags" = "Add Tags";
+"Tags" = "Tags";
 "Share" = "Share";
 
 "Saves" = "Saves";
@@ -106,6 +107,7 @@
 "Delete" = "Delete";
 "Cancel" = "Cancel";
 "Rename Tag" = "Rename Tag";
+"Rename" = "Rename";
 "Enter a new name for this tag" = "Enter a new name for this tag";
 
 "not tagged" = "not tagged";
@@ -131,6 +133,8 @@
 "search.limitedResults" = "Limited search results";
 "search.offlineMessage" = "You can only search titles and URLs while offline. Connect to the internet to use Premium's full-text search.";
 "search.banner.errorMessage." = "We’re experiencing an error and can’t show you full search results. Please try again later.";
+"search.error.view.needsInternet" = "You must have an internet connection to view this item.";
+"search.recent" = "Recent Searches";
 
 // Settings
 "settings.thankyou.credits" = "Thank you for using Pocket";
@@ -139,3 +143,6 @@
 "settings.logout" = "Log Out";
 "settings.logout.areYouSureMessage" = "You will be logged out of your account and any items that have been saved for offline viewing will be removed from your device.";
 "settings.logout.areyousure" = "Are you sure?";
+
+//List view
+"item.list.min" = "%@ min";

PocketKit/Sources/PocketKit/Strings.swift

@@ -129,6 +129,8 @@ internal enum L10n {
   internal static let privacyPolicy = L10n.tr("Localizable", "Privacy Policy", fallback: "Privacy Policy")
   /// Recent Saves
   internal static let recentSaves = L10n.tr("Localizable", "Recent Saves", fallback: "Recent Saves")
+  /// Rename
+  internal static let rename = L10n.tr("Localizable", "Rename", fallback: "Rename")
   /// Rename Tag
   internal static let renameTag = L10n.tr("Localizable", "Rename Tag", fallback: "Rename Tag")
   /// Report
@@ -173,6 +175,8 @@ internal enum L10n {
   internal static let tagYourSavesByTopicToFindThemLater = L10n.tr("Localizable", "Tag your saves by topic to find them later.", fallback: "Tag your saves by topic to find them later.")
   /// Tagged
   internal static let tagged = L10n.tr("Localizable", "Tagged", fallback: "Tagged")
+  /// Tags
+  internal static let tags = L10n.tr("Localizable", "Tags", fallback: "Tags")
   /// Tell us more
   internal static let tellUsMore = L10n.tr("Localizable", "Tell us more", fallback: "Tell us more")
   /// Terms of Service
@@ -202,6 +206,14 @@ internal enum L10n {
     /// Save from Safari, Twitter, YouTube or your favorite news app (for starters). Your articles and videos will be ready for you in Pocket
     internal static let yourArticlesAndVideosWillBeReadyForYouInPocket = L10n.tr("Localizable", "Save from Safari, Twitter, YouTube or your favorite news app (for starters). Your articles and videos will be ready for you in Pocket", fallback: "Save from Safari, Twitter, YouTube or your favorite news app (for starters). Your articles and videos will be ready for you in Pocket")
   }
+  internal enum Item {
+    internal enum List {
+      /// %@ min
+      internal static func min(_ p1: Any) -> String {
+        return L10n.tr("Localizable", "item.list.min", String(describing: p1), fallback: "%@ min")
+      }
+    }
+  }
   internal enum Search {
     /// Oops! Try again?
     internal static let errorHeadline = L10n.tr("Localizable", "search.errorHeadline", fallback: "Oops! Try again?")
@@ -211,10 +223,18 @@ internal enum L10n {
     internal static let limitedResults = L10n.tr("Localizable", "search.limitedResults", fallback: "Limited search results")
     /// You can only search titles and URLs while offline. Connect to the internet to use Premium's full-text search.
     internal static let offlineMessage = L10n.tr("Localizable", "search.offlineMessage", fallback: "You can only search titles and URLs while offline. Connect to the internet to use Premium's full-text search.")
+    /// Recent Searches
+    internal static let recent = L10n.tr("Localizable", "search.recent", fallback: "Recent Searches")
     internal enum Banner {
       /// We’re experiencing an error and can’t show you full search results. Please try again later.
       internal static let errorMessage = L10n.tr("Localizable", "search.banner.errorMessage.", fallback: "We’re experiencing an error and can’t show you full search results. Please try again later.")
     }
+    internal enum Error {
+      internal enum View {
+        /// You must have an internet connection to view this item.
+        internal static let needsInternet = L10n.tr("Localizable", "search.error.view.needsInternet", fallback: "You must have an internet connection to view this item.")
+      }
+    }
   }
   internal enum Settings {
     /// Log Out

PocketKit/Sources/PocketKit/Tags/TagsFilterView.swift

@@ -119,14 +119,14 @@ struct EditBottomBar: View {
 
     var body: some View {
         HStack {
-            Button("Rename") {
+            Button(L10n.rename) {
                 tagsSelected = selection
                 showRenameAlert = true
             }
             .disabled(selection.count != 1)
             .accessibilityIdentifier("rename-button")
             Spacer()
-            Button("Delete") {
+            Button(L10n.delete) {
                 tagsSelected = selection
                 showDeleteAlert = true
             }
@@ -145,7 +145,7 @@ struct TagsHeaderToolBar: ViewModifier {
             .toolbar {
                 ToolbarItem(placement: .principal) {
                     VStack {
-                        Text("Tags").style(.tagsFilter.sectionHeader)
+                        Text(L10n.tags).style(.tagsFilter.sectionHeader)
                     }
                 }
                 ToolbarItem(placement: .navigationBarLeading) {