Don't capture messages when encountering unsupported Particle elements

jacobsimeon · Jacob Morris · commit f8305fe938ce · 2021-07-29T17:15:49.000-07:00
These captures are causing a huge performance issue so disabling for
now. We can come up with a way to capture them in a more efficient
manner in the future.
diff --git a/PocketKit/Sources/Sync/Particle/Decodable/ArticleComponent+Decodable.swift b/PocketKit/Sources/Sync/Particle/Decodable/ArticleComponent+Decodable.swift
@@ -26,7 +26,6 @@ extension ArticleComponent: Decodable {
 
         guard let componentType = ComponentType(rawValue: rawType) else {
             self = .unsupported(rawType)
-            Crashlogger.capture(message: "Encountered unsupported \(ArticleComponent.self) type: \(rawType)")
             return
         }
 
diff --git a/PocketKit/Sources/Sync/Particle/Decodable/InlineModifer+Decodable.swift b/PocketKit/Sources/Sync/Particle/Decodable/InlineModifer+Decodable.swift
@@ -16,7 +16,6 @@ extension InlineModifier: Decodable {
         let container = try decoder.container(keyedBy: InlineModifierTypeKey.self)
         let typeString = try container.decode(String.self, forKey: .type)
         guard let type = InlineModifierType(rawValue: typeString) else {
-            Crashlogger.capture(message: "Encountered unsupported \(InlineModifier.self) type: \(typeString)")
             self = .unsupported(typeString)
             return
         }
diff --git a/PocketKit/Sources/Sync/Particle/Decodable/InlineStyle+Decodable.swift b/PocketKit/Sources/Sync/Particle/Decodable/InlineStyle+Decodable.swift
@@ -39,7 +39,6 @@ extension InlineStyle: Decodable {
             case .strong:
                 return .strong
             case .none:
-                Crashlogger.capture(message: "Encountered unsupported \(InlineStyle.self) type: \(rawStyle)")
                 return .unsupported(rawStyle)
             }
         }()

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,6 @@ extension ArticleComponent: Decodable {`
`26`	`26`
`27`	`27`	`guard let componentType = ComponentType(rawValue: rawType) else {`
`28`	`28`	`self = .unsupported(rawType)`
`29`		`- Crashlogger.capture(message: "Encountered unsupported \(ArticleComponent.self) type: \(rawType)")`
`30`	`29`	`return`
`31`	`30`	`}`
`32`	`31`
Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,6 @@ extension InlineModifier: Decodable {`
`16`	`16`	`let container = try decoder.container(keyedBy: InlineModifierTypeKey.self)`
`17`	`17`	`let typeString = try container.decode(String.self, forKey: .type)`
`18`	`18`	`guard let type = InlineModifierType(rawValue: typeString) else {`
`19`		`- Crashlogger.capture(message: "Encountered unsupported \(InlineModifier.self) type: \(typeString)")`
`20`	`19`	`self = .unsupported(typeString)`
`21`	`20`	`return`
`22`	`21`	`}`
Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,6 @@ extension InlineStyle: Decodable {`
`39`	`39`	`case .strong:`
`40`	`40`	`return .strong`
`41`	`41`	`case .none:`
`42`		`- Crashlogger.capture(message: "Encountered unsupported \(InlineStyle.self) type: \(rawStyle)")`
`43`	`42`	`return .unsupported(rawStyle)`
`44`	`43`	`}`
`45`	`44`	`}()`