Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write small test suite that ensures key variables produce impacts #930

Open
anth-volk opened this issue Aug 19, 2024 · 0 comments
Open

Write small test suite that ensures key variables produce impacts #930

anth-volk opened this issue Aug 19, 2024 · 0 comments

Comments

@anth-volk
Copy link
Collaborator

This is meant to complement PolicyEngine/policyengine-core#252. The root of the issue behind that PR was an incorrectly written line that, when executed, did not apply a reform correctly, causing a reform to generate the same impact as the baseline. We could use 5-10 tests for 5-10 super common variables of different types, and would just test to make sure that there is, in fact, an impact from each of these. Alternatively, we create dummy variables with formulas that give very predictable outputs and test for those exact outputs.

Testing for this in core would not be as effective as within the country package itself, as it could catch a wide net of unintended bugs that might impact the country model.

Duplicate of PolicyEngine/policyengine-us#4925.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant