Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FY2025 and fix FY2024 SNAP parameters based on SNAP Screener #5146

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

hua7450
Copy link
Collaborator

@hua7450 hua7450 commented Sep 26, 2024

Fixes #5115

@hua7450
Copy link
Collaborator Author

hua7450 commented Sep 26, 2024

Still a draft, detailed differences in this doc.

@vrathi101
Copy link
Collaborator

@hua7450 is this pr supposed to fix old values (FY 2023 and before) or update parameters with FY2024. If its the former, the dates should be fixed from 2024-10-01 to 2023-10-01 and if its the latter most of the states are missing updated values as shown in https://www.fns.usda.gov/snap/eligibility/deduction/standard-utility-allowances

@hua7450
Copy link
Collaborator Author

hua7450 commented Oct 6, 2024

@hua7450 is this pr supposed to fix old values (FY 2023 and before) or update parameters with FY2024. If its the former, the dates should be fixed from 2024-10-01 to 2023-10-01 and if its the latter most of the states are missing updated values as shown in https://www.fns.usda.gov/snap/eligibility/deduction/standard-utility-allowances

It’s the later. I have updated all the 2024 values in the utility folder. Those states that did not have 2024 values have the same values as they have in 2023. 

@vrathi101
Copy link
Collaborator

vrathi101 commented Oct 6, 2024

@hua7450 is this pr supposed to fix old values (FY 2023 and before) or update parameters with FY2024. If its the former, the dates should be fixed from 2024-10-01 to 2023-10-01 and if its the latter most of the states are missing updated values as shown in https://www.fns.usda.gov/snap/eligibility/deduction/standard-utility-allowances

It’s the later. I have updated all the 2024 values in the utility folder. Those states that did not have 2024 values have the same values as they have in 2023.

ok, in that case aren't you missing a ton of values,
for example in water utilities: Alaska = 57, colorado = 69, delaware = 99, DC = 88, etc. or am I misunderstanding? I circled some examples but there are a bunch more
Screenshot 2024-10-06 at 10 38 33 AM

@hua7450
Copy link
Collaborator Author

hua7450 commented Oct 8, 2024

@hua7450 is this pr supposed to fix old values (FY 2023 and before) or update parameters with FY2024. If its the former, the dates should be fixed from 2024-10-01 to 2023-10-01 and if its the latter most of the states are missing updated values as shown in https://www.fns.usda.gov/snap/eligibility/deduction/standard-utility-allowances

It’s the later. I have updated all the 2024 values in the utility folder. Those states that did not have 2024 values have the same values as they have in 2023.

ok, in that case aren't you missing a ton of values, for example in water utilities: Alaska = 57, colorado = 69, delaware = 99, DC = 88, etc. or am I misunderstanding? I circled some examples but there are a bunch more Screenshot 2024-10-06 at 10 38 33 AM

Yes, I will double-check and add more to it.

@hua7450 hua7450 changed the title Fix 2024 SNAP parameters based on SNAP Screener Update 2024 SNAP parameters based on SNAP Screener Oct 9, 2024
@hua7450
Copy link
Collaborator Author

hua7450 commented Oct 13, 2024

@vrathi101 I just checked, I think you are looking at the Excel sheet for FY 2025, USDA recently updated the Excel sheet for utility in October. That's why the values you see are different from mine.
image

@vrathi101
Copy link
Collaborator

@vrathi101 I just checked, I think you are looking at the Excel sheet for FY 2025, USDA recently updated the Excel sheet for utility in October. That's why the values you see are different from mine. image

i see, my bad for that

@hua7450 hua7450 changed the title Update 2024 SNAP parameters based on SNAP Screener Update FY2025 and fix FY2024 SNAP parameters based on SNAP Screener Oct 16, 2024
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.00%. Comparing base (cb92a56) to head (5292cde).
Report is 130 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5146      +/-   ##
==========================================
- Coverage   99.12%   99.00%   -0.13%     
==========================================
  Files        2592     2613      +21     
  Lines       37707    38068     +361     
  Branches      162      168       +6     
==========================================
+ Hits        37378    37689     +311     
- Misses        297      346      +49     
- Partials       32       33       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hua7450 hua7450 marked this pull request as ready for review November 12, 2024 22:58
@MaxGhenis
Copy link
Contributor

@PavelMakarchuk could you please review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update 2024 and 2025 SNAP parameters based on SNAP Screener
5 participants