Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📒 Add Ledger support #398

Merged
merged 1 commit into from
Sep 12, 2024
Merged

📒 Add Ledger support #398

merged 1 commit into from
Sep 12, 2024

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented Sep 9, 2024

What?

  • Add support for the Ledger hardware wallet

How?

  • Add a new signed extension to the runtime, and conditional build of the wasm.

Testing?

@lrazovic can you try it out with zombienet since you have a ledger nano?

Anything Else?

There are 2 places where I had to initialise the signed extensions with ::new(), but not sure if the argument inside should be true or false. I set it to true

@JuaniRios JuaniRios changed the title Add Ledger support 📒 Add Ledger support Sep 9, 2024
@JuaniRios JuaniRios force-pushed the 09-09-add_ledger_support branch 4 times, most recently from 009e25f to 291568a Compare September 9, 2024 13:10
@JuaniRios JuaniRios self-assigned this Sep 9, 2024
@JuaniRios JuaniRios requested review from lrazovic and vstam1 September 9, 2024 13:11
@JuaniRios JuaniRios marked this pull request as ready for review September 9, 2024 13:13
@JuaniRios JuaniRios force-pushed the 09-04-slash_behavior_on_pallet_vesting branch from a6828af to 5e2c3a4 Compare September 10, 2024 08:35
@JuaniRios JuaniRios force-pushed the 09-09-add_ledger_support branch from 291568a to ded6423 Compare September 10, 2024 08:35
@JuaniRios JuaniRios force-pushed the 09-04-slash_behavior_on_pallet_vesting branch from 5e2c3a4 to fdf5426 Compare September 10, 2024 08:43
@JuaniRios JuaniRios force-pushed the 09-09-add_ledger_support branch from ded6423 to ff9f101 Compare September 10, 2024 08:44
@lrazovic lrazovic force-pushed the 09-04-slash_behavior_on_pallet_vesting branch from fdf5426 to 74624f3 Compare September 10, 2024 13:45
@JuaniRios JuaniRios force-pushed the 09-04-slash_behavior_on_pallet_vesting branch from 88e56a7 to bade02e Compare September 11, 2024 11:15
@JuaniRios JuaniRios force-pushed the 09-09-add_ledger_support branch from ff9f101 to 6734b0c Compare September 11, 2024 11:15
@JuaniRios JuaniRios force-pushed the 09-04-slash_behavior_on_pallet_vesting branch from bade02e to d9ac4a4 Compare September 11, 2024 11:23
@JuaniRios JuaniRios force-pushed the 09-09-add_ledger_support branch from 6734b0c to cfbf0ef Compare September 11, 2024 11:23
@JuaniRios JuaniRios force-pushed the 09-04-slash_behavior_on_pallet_vesting branch from d9ac4a4 to b86d878 Compare September 11, 2024 11:31
@JuaniRios JuaniRios force-pushed the 09-09-add_ledger_support branch from cfbf0ef to 5c97cb0 Compare September 11, 2024 11:31
@JuaniRios JuaniRios force-pushed the 09-04-slash_behavior_on_pallet_vesting branch from b86d878 to 4674903 Compare September 12, 2024 08:35
@JuaniRios JuaniRios force-pushed the 09-09-add_ledger_support branch 2 times, most recently from 2e7825f to 958304f Compare September 12, 2024 08:41
@JuaniRios JuaniRios force-pushed the 09-04-slash_behavior_on_pallet_vesting branch from 4674903 to 20bda10 Compare September 12, 2024 11:02
@JuaniRios JuaniRios force-pushed the 09-09-add_ledger_support branch 2 times, most recently from 2a14aa9 to 670eeae Compare September 12, 2024 13:39
Copy link
Contributor Author

JuaniRios commented Sep 12, 2024

Merge activity

  • Sep 12, 9:39 AM EDT: @JuaniRios started a stack merge that includes this pull request via Graphite.
  • Sep 12, 9:57 AM EDT: Graphite rebased this pull request as part of a merge.
  • Sep 12, 9:58 AM EDT: @JuaniRios merged this pull request with Graphite.

@JuaniRios JuaniRios mentioned this pull request Sep 12, 2024
@JuaniRios JuaniRios changed the base branch from 09-04-slash_behavior_on_pallet_vesting to graphite-base/398 September 12, 2024 13:53
@JuaniRios JuaniRios changed the base branch from graphite-base/398 to main September 12, 2024 13:55
@JuaniRios JuaniRios force-pushed the 09-09-add_ledger_support branch from 670eeae to 4eb68fe Compare September 12, 2024 13:56
@JuaniRios JuaniRios merged commit 862d1b9 into main Sep 12, 2024
1 check passed
@JuaniRios JuaniRios deleted the 09-09-add_ledger_support branch September 12, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants