Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🧪 Test USDT transaction payment #404

Merged
merged 1 commit into from
Oct 10, 2024
Merged

🧪 Test USDT transaction payment #404

merged 1 commit into from
Oct 10, 2024

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented Sep 27, 2024 •
edited
Loading

What?

  • Add an integration test to check the new USDT payment of transaction fees and tips.

Testing?

integration_tests::transaction_payment::fee_paid_with_foreign_assets

This was referenced Sep 27, 2024
Merged
Merged
Merged
@JuaniRios Graphite App
Copy link
Contributor Author

JuaniRios commented Sep 27, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @JuaniRios and the rest of your teammates on Graphite Graphite

@JuaniRios JuaniRios mentioned this pull request Sep 27, 2024
Merged
@JuaniRios JuaniRios force-pushed the 09-27-test_usdt_transaction_payment branch from 095737a to 6dd401c Compare September 30, 2024 12:19
@JuaniRios JuaniRios self-assigned this Sep 30, 2024
@JuaniRios JuaniRios force-pushed the 09-24-usdt_transaction_payment branch from 64e8904 to b17ad86 Compare September 30, 2024 12:52
@JuaniRios JuaniRios force-pushed the 09-27-test_usdt_transaction_payment branch from 6dd401c to 3380a83 Compare September 30, 2024 12:52
@JuaniRios JuaniRios force-pushed the 09-24-usdt_transaction_payment branch from b17ad86 to 881ae63 Compare September 30, 2024 12:58
@JuaniRios JuaniRios force-pushed the 09-27-test_usdt_transaction_payment branch from 3380a83 to 55ab6b0 Compare September 30, 2024 12:58
@JuaniRios JuaniRios force-pushed the 09-24-usdt_transaction_payment branch from 881ae63 to a0d191f Compare September 30, 2024 13:00
@JuaniRios JuaniRios force-pushed the 09-27-test_usdt_transaction_payment branch from 55ab6b0 to 162dc7f Compare September 30, 2024 13:00
@JuaniRios JuaniRios force-pushed the 09-24-usdt_transaction_payment branch from a0d191f to d1269bb Compare September 30, 2024 13:05
@JuaniRios JuaniRios force-pushed the 09-27-test_usdt_transaction_payment branch from 162dc7f to 03a7bfa Compare September 30, 2024 13:06
@JuaniRios JuaniRios force-pushed the 09-24-usdt_transaction_payment branch from d1269bb to 0d68b35 Compare September 30, 2024 13:12
@JuaniRios JuaniRios force-pushed the 09-27-test_usdt_transaction_payment branch from 03a7bfa to ba491b0 Compare September 30, 2024 13:12
@JuaniRios JuaniRios force-pushed the 09-24-usdt_transaction_payment branch from 0d68b35 to dd2d227 Compare September 30, 2024 13:15
@JuaniRios JuaniRios force-pushed the 09-27-test_usdt_transaction_payment branch from ba491b0 to c9b18ca Compare September 30, 2024 13:15
@JuaniRios JuaniRios marked this pull request as ready for review September 30, 2024 13:19
@JuaniRios JuaniRios changed the title Test USDT transaction payment 🧪 Test USDT transaction payment Sep 30, 2024
@JuaniRios JuaniRios force-pushed the 09-24-usdt_transaction_payment branch from dd2d227 to a6346c6 Compare October 1, 2024 09:20
@JuaniRios JuaniRios force-pushed the 09-27-test_usdt_transaction_payment branch from c9b18ca to 4c8d6cf Compare October 1, 2024 09:20
@JuaniRios JuaniRios mentioned this pull request Oct 1, 2024
Merged
@JuaniRios JuaniRios force-pushed the 09-24-usdt_transaction_payment branch from a6346c6 to ae7c837 Compare October 3, 2024 13:49
@JuaniRios JuaniRios force-pushed the 09-27-test_usdt_transaction_payment branch from 4c8d6cf to f00ff56 Compare October 3, 2024 13:49
@JuaniRios JuaniRios force-pushed the 09-24-usdt_transaction_payment branch from ae7c837 to 7a44974 Compare October 3, 2024 14:51
@JuaniRios JuaniRios force-pushed the 09-27-test_usdt_transaction_payment branch from f00ff56 to 618f4e5 Compare October 3, 2024 14:51
@lrazovic lrazovic force-pushed the 09-27-test_usdt_transaction_payment branch from 6da7c33 to 6753c44 Compare October 8, 2024 13:27
@JuaniRios JuaniRios force-pushed the 09-24-usdt_transaction_payment branch from 0711b4f to cc0ed0d Compare October 9, 2024 09:59
@JuaniRios JuaniRios force-pushed the 09-27-test_usdt_transaction_payment branch from 6753c44 to 2d14e69 Compare October 9, 2024 09:59
lrazovic
lrazovic requested changes Oct 9, 2024
View reviewed changes
Copy link
Member

@lrazovic lrazovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few questions around the dispatch len, the logic looks good.

integration-tests/src/tests/transaction_payment.rs Show resolved Hide resolved
integration-tests/src/tests/transaction_payment.rs Show resolved Hide resolved
integration-tests/src/tests/transaction_payment.rs Outdated Show resolved Hide resolved
integration-tests/src/tests/transaction_payment.rs Outdated Show resolved Hide resolved
integration-tests/src/tests/transaction_payment.rs Outdated Show resolved Hide resolved
integration-tests/src/tests/transaction_payment.rs Outdated Show resolved Hide resolved
integration-tests/src/tests/transaction_payment.rs Outdated Show resolved Hide resolved
integration-tests/src/tests/transaction_payment.rs Outdated Show resolved Hide resolved
integration-tests/src/tests/transaction_payment.rs Outdated Show resolved Hide resolved
runtimes/shared-configuration/src/fee.rs Show resolved Hide resolved
@JuaniRios JuaniRios mentioned this pull request Oct 9, 2024
Merged
@JuaniRios JuaniRios force-pushed the 09-27-test_usdt_transaction_payment branch 3 times, most recently from a84b5eb to 1d2cbe4 Compare October 10, 2024 09:53
@JuaniRios JuaniRios requested a review from lrazovic October 10, 2024 10:58
@JuaniRios JuaniRios mentioned this pull request Oct 10, 2024
Merged
@lrazovic lrazovic force-pushed the 09-24-usdt_transaction_payment branch from cc0ed0d to 55f4136 Compare October 10, 2024 11:57
@lrazovic lrazovic force-pushed the 09-27-test_usdt_transaction_payment branch from 1d2cbe4 to d2bc6b8 Compare October 10, 2024 11:58
@lrazovic lrazovic mentioned this pull request Oct 10, 2024
Merged
@JuaniRios JuaniRios force-pushed the 09-24-usdt_transaction_payment branch from 55f4136 to cc0ed0d Compare October 10, 2024 11:59
@JuaniRios JuaniRios force-pushed the 09-27-test_usdt_transaction_payment branch from d2bc6b8 to 1d2cbe4 Compare October 10, 2024 11:59
@JuaniRios JuaniRios mentioned this pull request Oct 10, 2024
Merged
@lrazovic lrazovic force-pushed the 09-24-usdt_transaction_payment branch from cc0ed0d to 55f4136 Compare October 10, 2024 12:20
@lrazovic lrazovic force-pushed the 09-27-test_usdt_transaction_payment branch from 1d2cbe4 to d2bc6b8 Compare October 10, 2024 12:20
@JuaniRios JuaniRios force-pushed the 09-24-usdt_transaction_payment branch from 55f4136 to cc0ed0d Compare October 10, 2024 12:22
@JuaniRios JuaniRios force-pushed the 09-27-test_usdt_transaction_payment branch from d2bc6b8 to 1d2cbe4 Compare October 10, 2024 12:22
@JuaniRios JuaniRios force-pushed the 09-24-usdt_transaction_payment branch from cc0ed0d to 26e32e8 Compare October 10, 2024 13:46
@JuaniRios JuaniRios force-pushed the 09-27-test_usdt_transaction_payment branch from 1d2cbe4 to 56cd657 Compare October 10, 2024 13:46
@JuaniRios Graphite App
Copy link
Contributor Author

JuaniRios commented Oct 10, 2024 •
edited
Loading

Merge activity

  • Oct 10, 10:08 AM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Oct 10, 10:19 AM EDT: Graphite rebased this pull request as part of a merge.
  • Oct 10, 10:20 AM EDT: A user merged this pull request with Graphite.

@JuaniRios JuaniRios changed the base branch from 09-24-usdt_transaction_payment to graphite-base/404 October 10, 2024 14:15
@JuaniRios JuaniRios changed the base branch from graphite-base/404 to main October 10, 2024 14:17
@JuaniRios JuaniRios force-pushed the 09-27-test_usdt_transaction_payment branch from 56cd657 to e0bc143 Compare October 10, 2024 14:18
@JuaniRios JuaniRios merged commit 4fa0931 into main Oct 10, 2024
1 check passed
@JuaniRios JuaniRios deleted the 09-27-test_usdt_transaction_payment branch October 10, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrazovic lrazovic lrazovic approved these changes

@vstam1 vstam1 Awaiting requested review from vstam1

Assignees

@JuaniRios JuaniRios

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JuaniRios @lrazovic