Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ Fix funding asset ED tests #408

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented Oct 7, 2024

What?

  • Fix all tests

Why?

  • They were failing due to a USDT ED now being required

How?

  • Create new inst functions to mint the ed and call them in all tests.

@lrazovic lrazovic force-pushed the 10-04-usdt-fee-pjs-compatibility branch 2 times, most recently from 8b80f9b to 17de30f Compare October 8, 2024 13:29
@JuaniRios JuaniRios changed the title fix funding asset ed tests ✅ Fix funding asset ED tests Oct 9, 2024
@JuaniRios JuaniRios marked this pull request as ready for review October 9, 2024 09:59
@JuaniRios JuaniRios force-pushed the 10-04-usdt-fee-pjs-compatibility branch from 17de30f to 339eefb Compare October 9, 2024 10:00
Copy link

graphite-app bot commented Oct 9, 2024

Graphite Automations

"Auto-assign PRs to author" took an action on this PR • (10/09/24)

1 assignee was added to this PR based on Juan Ignacio Rios's automation.

@JuaniRios JuaniRios force-pushed the 10-04-fix_funding_asset_ed_tests branch from 88e599f to ca5c1f7 Compare October 9, 2024 10:00
@JuaniRios JuaniRios force-pushed the 10-04-usdt-fee-pjs-compatibility branch from 339eefb to 5e8b4f5 Compare October 10, 2024 09:37
@JuaniRios JuaniRios force-pushed the 10-04-fix_funding_asset_ed_tests branch from ca5c1f7 to 4e31469 Compare October 10, 2024 09:37
@JuaniRios JuaniRios force-pushed the 10-04-usdt-fee-pjs-compatibility branch from 5e8b4f5 to 3701e31 Compare October 10, 2024 09:39
@JuaniRios JuaniRios force-pushed the 10-04-fix_funding_asset_ed_tests branch from 4e31469 to 1d24782 Compare October 10, 2024 09:39
@JuaniRios JuaniRios force-pushed the 10-04-usdt-fee-pjs-compatibility branch from 3701e31 to 53d5063 Compare October 10, 2024 09:43
@JuaniRios JuaniRios force-pushed the 10-04-fix_funding_asset_ed_tests branch from 1d24782 to 5abe0bb Compare October 10, 2024 09:43
@JuaniRios JuaniRios force-pushed the 10-04-usdt-fee-pjs-compatibility branch from 53d5063 to b7d6648 Compare October 10, 2024 09:53
@JuaniRios JuaniRios force-pushed the 10-04-fix_funding_asset_ed_tests branch from 5abe0bb to 662529b Compare October 10, 2024 09:53
@JuaniRios JuaniRios requested review from lrazovic and vstam1 October 10, 2024 10:58
@lrazovic lrazovic force-pushed the 10-04-usdt-fee-pjs-compatibility branch from b7d6648 to 6ac47a9 Compare October 10, 2024 11:58
@lrazovic lrazovic force-pushed the 10-04-fix_funding_asset_ed_tests branch from 662529b to d6faab3 Compare October 10, 2024 11:58
@JuaniRios JuaniRios force-pushed the 10-04-usdt-fee-pjs-compatibility branch from 6ac47a9 to b7d6648 Compare October 10, 2024 12:00
@JuaniRios JuaniRios force-pushed the 10-04-fix_funding_asset_ed_tests branch from d6faab3 to 662529b Compare October 10, 2024 12:00
@lrazovic lrazovic force-pushed the 10-04-usdt-fee-pjs-compatibility branch from b7d6648 to 6ac47a9 Compare October 10, 2024 12:20
@lrazovic lrazovic force-pushed the 10-04-fix_funding_asset_ed_tests branch from 662529b to d6faab3 Compare October 10, 2024 12:20
@JuaniRios JuaniRios force-pushed the 10-04-usdt-fee-pjs-compatibility branch from 6ac47a9 to b7d6648 Compare October 10, 2024 12:23
@JuaniRios JuaniRios force-pushed the 10-04-fix_funding_asset_ed_tests branch from d6faab3 to 662529b Compare October 10, 2024 12:23
@JuaniRios JuaniRios force-pushed the 10-04-usdt-fee-pjs-compatibility branch from b7d6648 to ae385b1 Compare October 10, 2024 13:47
@JuaniRios JuaniRios force-pushed the 10-04-fix_funding_asset_ed_tests branch from 662529b to 75a6225 Compare October 10, 2024 13:47
Copy link
Contributor Author

JuaniRios commented Oct 10, 2024

Merge activity

  • Oct 10, 10:08 AM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Oct 10, 10:28 AM EDT: Graphite rebased this pull request as part of a merge.
  • Oct 10, 10:29 AM EDT: A user merged this pull request with Graphite.

@JuaniRios JuaniRios changed the base branch from 10-04-usdt-fee-pjs-compatibility to graphite-base/408 October 10, 2024 14:24
@JuaniRios JuaniRios changed the base branch from graphite-base/408 to main October 10, 2024 14:26
@JuaniRios JuaniRios force-pushed the 10-04-fix_funding_asset_ed_tests branch from 75a6225 to 5f44c41 Compare October 10, 2024 14:27
@JuaniRios JuaniRios merged commit 7cd82a2 into main Oct 10, 2024
1 check passed
@JuaniRios JuaniRios deleted the 10-04-fix_funding_asset_ed_tests branch October 10, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants