Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ ETH Compatibility Tests #425

Open
wants to merge 3 commits into
base: 10-14-ethereum_compatibility
Choose a base branch
from

Conversation

JuaniRios
Copy link
Contributor

@JuaniRios JuaniRios commented Oct 24, 2024

What?

  • Add tests

How?

  • Test each new extrinsic
  • Test an ethereum project can be successfully funded
  • Test that the migration info is correctly setup with either the ETH or DOT account

@JuaniRios JuaniRios force-pushed the 10-24-eth_compat._tests branch from c3a0720 to 7961f2e Compare October 24, 2024 09:37
Copy link
Contributor Author

JuaniRios commented Oct 24, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@JuaniRios JuaniRios force-pushed the 10-14-ethereum_compatibility branch from 1cc1e7b to 1da3b0a Compare October 24, 2024 09:38
@JuaniRios JuaniRios force-pushed the 10-24-eth_compat._tests branch 2 times, most recently from c819f56 to 1413c23 Compare October 24, 2024 09:40
integration-tests/src/tests/ethereum_support.rs Outdated Show resolved Hide resolved
pallets/funding/src/tests/misc.rs Outdated Show resolved Hide resolved
@JuaniRios JuaniRios force-pushed the 10-14-ethereum_compatibility branch from 1da3b0a to 2fd7129 Compare October 24, 2024 09:41
@JuaniRios JuaniRios force-pushed the 10-24-eth_compat._tests branch from 1413c23 to d269daa Compare October 24, 2024 09:41
@JuaniRios JuaniRios force-pushed the 10-14-ethereum_compatibility branch from 2fd7129 to 252f99a Compare October 24, 2024 10:59
@JuaniRios JuaniRios force-pushed the 10-24-eth_compat._tests branch from d269daa to 88aabca Compare October 24, 2024 10:59
@JuaniRios JuaniRios force-pushed the 10-14-ethereum_compatibility branch from 252f99a to 85c8505 Compare October 24, 2024 11:00
@JuaniRios JuaniRios force-pushed the 10-24-eth_compat._tests branch from 88aabca to f7cd35f Compare October 24, 2024 11:01
@JuaniRios JuaniRios changed the title eth compat. tests ✅ ETH Compatibility Tests Oct 24, 2024
@JuaniRios JuaniRios force-pushed the 10-24-eth_compat._tests branch from f7cd35f to 8a90f38 Compare October 24, 2024 12:51
@JuaniRios JuaniRios force-pushed the 10-24-eth_compat._tests branch 10 times, most recently from 89e6c7e to e552785 Compare October 30, 2024 14:38
@JuaniRios JuaniRios marked this pull request as ready for review October 30, 2024 14:46
@JuaniRios JuaniRios requested review from lrazovic and vstam1 October 30, 2024 14:46
@lrazovic lrazovic requested a review from Lederstrumpf October 30, 2024 14:47
Copy link

graphite-app bot commented Oct 30, 2024

Graphite Automations

"Auto-assign PRs to author" took an action on this PR • (10/30/24)

1 assignee was added to this PR based on Juan Ignacio Rios's automation.

Copy link
Collaborator

@Lederstrumpf Lederstrumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2024-11-09T22:36:09,392811972+01:00

Brah, u no run integration tests on a testing PR? 💯

lgtm with tests fixed - otherwise only minor nits below.

pallets/funding/src/instantiator/traits.rs Outdated Show resolved Hide resolved
pallets/funding/src/tests/misc.rs Outdated Show resolved Hide resolved
@JuaniRios JuaniRios force-pushed the 10-24-eth_compat._tests branch from 669b73b to 35b2861 Compare November 27, 2024 13:30
@JuaniRios JuaniRios force-pushed the 10-14-ethereum_compatibility branch from 7f4bc03 to 307c6ba Compare November 27, 2024 15:56
@JuaniRios JuaniRios force-pushed the 10-24-eth_compat._tests branch from 35b2861 to 43fa9e6 Compare November 27, 2024 15:56
@JuaniRios JuaniRios force-pushed the 10-14-ethereum_compatibility branch from 307c6ba to 6e95419 Compare November 28, 2024 11:48
@JuaniRios JuaniRios force-pushed the 10-24-eth_compat._tests branch from 43fa9e6 to 946f64d Compare November 28, 2024 11:49
@JuaniRios JuaniRios force-pushed the 10-14-ethereum_compatibility branch from 6e95419 to 098e693 Compare November 28, 2024 11:52
@JuaniRios JuaniRios force-pushed the 10-24-eth_compat._tests branch from 946f64d to fe71617 Compare November 28, 2024 11:53
@JuaniRios JuaniRios force-pushed the 10-14-ethereum_compatibility branch from 098e693 to e12717a Compare November 28, 2024 12:06
@JuaniRios JuaniRios force-pushed the 10-24-eth_compat._tests branch from 06a8e9e to 57f33f9 Compare November 28, 2024 12:06
This was referenced Nov 29, 2024
This was referenced Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants