Allow to only show the amount of keys needed for given song

[othello777]

Optional Feature: Different songs use a different amount of the piano. no point in showing all 88 keys if the song doesn't use it all. some such as myself may see it as a waste of screen real estate. Would be a cool feature to have it show "Only song keys" + a user defined number of padding keys or to next C.

[PolyMeilex]

This got partially implemented in 0.2, but I'm leaving this open as the idea of auto sizing based on a song is still not there, and would be cool to have.

[JoeAckroyd]

@PolyMeilex is the note range settings available in the cli app?

[PolyMeilex]

@PolyMeilex is the note range settings available in the cli app?

Yep, but only in the config file (not tested tho)

[JoeAckroyd]

@PolyMeilex is the note range settings available in the cli app?

Yep, but only in the config file (not tested tho)

hmm ok i changed it to
fn default_piano_range() -> (u8, u8) { (27, 101) }

in the config, but it's not worked. I just changed that line, and re compiled the cli. am i missing anything (never used rust before 😬)

thanks!

[PolyMeilex]

What's your platform? The config is a .ron file, in the .config/Neothesia directory on Linux, on windows it's just in the same dir as the binary run director.
You essentially changed the default config rather than the config itself.
Another way would be to run neothesia edit the settings and then run the cli, they share the same .ron config file

[JoeAckroyd]

Hey @PolyMeilex ! I'm on mac, it was in the .github/app/Neothesia.app/Contents/Resources dir.

however, now ive changed it, the waterfall doesn't line up with the keys? is there another setting i need to change?

thanks so much for the help!!!

[PolyMeilex]

That's a bug, I belive this is now fixed on main.

Although looking at the code I'm supprised that the config loaded succesfully in CLI mode at all. It was written in a way that assumes that the app has a macOS bundle, and noethesia-cli does not have one, so I'm not sure how macOS knows where to look for the config. I suppose I should change it to look for config.ron in current working directory like it is done on Windows.