From bc4cca20e8f782dc52437076327a70722aecf37d Mon Sep 17 00:00:00 2001 From: MicrocontrollersDev <66657148+MicrocontrollersDev@users.noreply.github.com> Date: Fri, 15 Nov 2024 22:06:49 -0600 Subject: [PATCH 1/2] use lithium's initialization method --- .../mixins/performance/MathHelperMixin_CompactLUT.java | 3 +-- .../mods/lithium/common/util/math/CompactSineLUT.java | 4 ++++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/main/java/club/sk1er/patcher/mixins/performance/MathHelperMixin_CompactLUT.java b/src/main/java/club/sk1er/patcher/mixins/performance/MathHelperMixin_CompactLUT.java index bd5949d1..549d611e 100644 --- a/src/main/java/club/sk1er/patcher/mixins/performance/MathHelperMixin_CompactLUT.java +++ b/src/main/java/club/sk1er/patcher/mixins/performance/MathHelperMixin_CompactLUT.java @@ -14,10 +14,9 @@ public class MathHelperMixin_CompactLUT { @Final private static float[] SIN_TABLE; - @SuppressWarnings("InstantiationOfUtilityClass") @Inject(method = "", at = @At("RETURN")) private static void clearSinTable(CallbackInfo ci) { - new CompactSineLUT(); // Force class initialisation + CompactSineLUT.init(); // Force class initialisation MathHelperMixin_CompactLUT.SIN_TABLE = null; } diff --git a/src/main/java/me/jellysquid/mods/lithium/common/util/math/CompactSineLUT.java b/src/main/java/me/jellysquid/mods/lithium/common/util/math/CompactSineLUT.java index 6d1e4946..7af67dfa 100644 --- a/src/main/java/me/jellysquid/mods/lithium/common/util/math/CompactSineLUT.java +++ b/src/main/java/me/jellysquid/mods/lithium/common/util/math/CompactSineLUT.java @@ -79,6 +79,10 @@ public class CompactSineLUT { } } + public static void init() { + // This is just to force class initialization + } + // [VanillaCopy] MathHelper#sin(float) public static float sin(float f) { return lookup((int) (f * 10430.378f) & 0xFFFF); From a8863695379db4459f0122d9c2af1e7f194e5b09 Mon Sep 17 00:00:00 2001 From: MicrocontrollersDev <66657148+MicrocontrollersDev@users.noreply.github.com> Date: Tue, 3 Dec 2024 22:46:15 -0600 Subject: [PATCH 2/2] spelling consistency --- .../patcher/mixins/performance/MathHelperMixin_CompactLUT.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/club/sk1er/patcher/mixins/performance/MathHelperMixin_CompactLUT.java b/src/main/java/club/sk1er/patcher/mixins/performance/MathHelperMixin_CompactLUT.java index 549d611e..5486a4dc 100644 --- a/src/main/java/club/sk1er/patcher/mixins/performance/MathHelperMixin_CompactLUT.java +++ b/src/main/java/club/sk1er/patcher/mixins/performance/MathHelperMixin_CompactLUT.java @@ -16,7 +16,7 @@ public class MathHelperMixin_CompactLUT { @Inject(method = "", at = @At("RETURN")) private static void clearSinTable(CallbackInfo ci) { - CompactSineLUT.init(); // Force class initialisation + CompactSineLUT.init(); // Force class initialization MathHelperMixin_CompactLUT.SIN_TABLE = null; }