Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Method to locate nearest biome #456

Open
4 tasks done
Browsit opened this issue Apr 29, 2024 · 0 comments
Open
4 tasks done

[Feature] Method to locate nearest biome #456

Browsit opened this issue Apr 29, 2024 · 0 comments
Labels
Note: Good First Issue Good for anyone looking to learn the internals of Terra Platform: All Issue/PR is applicable to all platforms. Status: Accepted Issue/PR is accepted. Subsystem: External API Issue/PR has something to do with the external API. (Mainly addons) Type: Enhancement A request for a new feature or enhancement to be added.

Comments

@Browsit
Copy link
Contributor

Browsit commented Apr 29, 2024

  • I have checked that I am on the latest version of Terra.
  • I have searched github for similar features requests, including closed
    ones, and found none.
  • I believe this is within the scope of Terra.
  • This feature request is for all of Terra, and isn't something that
    should be implemented by a pack or addon.

Feature Description

An API method to locate the nearest Terra biome.

What Problem Does This Solve?

Currently, it is possible to locate Terra biomes in-game via a command with the syntax of /locate biome terra:packname/packname/biomename but there is no API equivalent of this. The closest is Bukkit's World#locateNearestBiome which, of course, does not accept a com.dfsek.terra.api.world.biome.Biome (and doesn't seem to work with org.bukkit.block.Biome on Terra worlds either, even if acquired through a BiomeProvider).

A Solution You'd Like

A method of similar functionality to locateNearestBiome but which accepts com.dfsek.terra.api.world.biome.Biome instead.

Alternative Solutions (that don't work)

  1. Bukkit's method but with a Biome acquired through ChunkGenerator -> BiomeProvider (simply using World#getBiome would return Biome.CUSTOM). Tested on Paper 1.20.4.

Additonal Context

We're looking to perform actions programmatically based on the result; the /locate command is insufficient.

@Browsit Browsit added Status: Pending Issue/PR is currently awaiting approval by a moderator. Type: Enhancement A request for a new feature or enhancement to be added. labels Apr 29, 2024
@solonovamax solonovamax added Note: Good First Issue Good for anyone looking to learn the internals of Terra Status: Accepted Issue/PR is accepted. Subsystem: External API Issue/PR has something to do with the external API. (Mainly addons) Platform: All Issue/PR is applicable to all platforms. and removed Status: Pending Issue/PR is currently awaiting approval by a moderator. labels Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Note: Good First Issue Good for anyone looking to learn the internals of Terra Platform: All Issue/PR is applicable to all platforms. Status: Accepted Issue/PR is accepted. Subsystem: External API Issue/PR has something to do with the external API. (Mainly addons) Type: Enhancement A request for a new feature or enhancement to be added.
Projects
None yet
Development

No branches or pull requests

2 participants