Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset description #20

Open
jere1882 opened this issue Oct 17, 2024 · 2 comments
Open

Dataset description #20

jere1882 opened this issue Oct 17, 2024 · 2 comments

Comments

@jere1882
Copy link

I am reproducing your experiments with your own data as well as data from a different survey.

I couldn't find any reference in the paper or in the code about the units in which the spectra data is represented in your dataset. Supposedly the data was obtained from DESI early release, in which case the spectra values are in 10^-17 erg s^-1 cm^-2 A^-1. Is this the case, or has the scale or units of the data been changed in the exported dataset?

Thank you very much, this project is amazing.

@lsarra
Copy link
Contributor

lsarra commented Oct 26, 2024

Hi! Yes, I would say we are using the data as it comes from the release (i.e. exactly what you would get from DESI, see here https://github.com/lsarra/astrolit/blob/5d9c9fceba78d2c0be7f5c36e45cf97940a2e583/astro_utils.py#L188-L198)

But for a definitive answer let's see what @EiffL or @lhparker1 say!

@jere1882
Copy link
Author

jere1882 commented Nov 4, 2024

thank you very much for your prompt response. Actually, it looks like the dataset you exported is applying some type of centering to the data, since the flux has negative values, while fluxes should always be positive.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants