From e95ce0fe334a764f11ce2e3a9cafce9e89149e9d Mon Sep 17 00:00:00 2001 From: derconno Date: Mon, 12 Aug 2024 22:35:00 +0200 Subject: [PATCH] closed results in GetUsernamesWithNoneAuth before performing another query. --- users/user.go | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/users/user.go b/users/user.go index 31607a4..c2df13b 100644 --- a/users/user.go +++ b/users/user.go @@ -144,17 +144,24 @@ func GetUserForNFCToken(ctx context.Context, token []byte, db *sql.DB) (User, er func GetUsernamesWithNoneAuth(ctx context.Context, db *sql.DB) ([]string, error) { result, err := db.QueryContext(ctx, `SELECT user_id FROM auth WHERE type = 'none'`) - defer result.Close() if err != nil { return nil, err } - names := make([]string, 0) + userIds := make([]string, 0) for result.Next() { var userId string err = result.Scan(&userId) if err != nil { continue } + userIds = append(userIds, userId) + } + err = result.Close() + if err != nil { + return nil, err + } + names := make([]string, 0) + for _, userId := range userIds { user, err := GetUserForId(ctx, userId, db) if err != nil { continue