Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CVE-2023-25690 vulnerability script the false positive rate is too high #181

Open
JaveleyQAQ opened this issue Feb 21, 2024 · 6 comments · Fixed by #182
Open

CVE-2023-25690 vulnerability script the false positive rate is too high #181

JaveleyQAQ opened this issue Feb 21, 2024 · 6 comments · Fixed by #182
Labels
bug Something isn't working good first issue Good for newcomers template Issue in BCheck template

Comments

@JaveleyQAQ
Copy link
Contributor

For the CVE-2023-25690 vulnerability script, the false positive rate is too high.
In default scanning mode, Burp Suite cannot distinguish static files, leading to a higher false positive rate.
For example, when accessing http://example.com/test.js?v=1 if the script's payload is added on this basis, false positive results will be generated.
image

I have not conducted in-depth research on this vulnerability, so I cannot provide detailed recommendations. However, relying solely on the "split" request response code as the basis for the vulnerability is clearly not rigorous enough.

@JaveleyQAQ JaveleyQAQ added the bug Something isn't working label Feb 21, 2024
@Michelle-PortSwigger
Copy link
Contributor

Hi

This is a BCheck that was originally written by one of the community members rather than one of us here at PortSwigger.

Have you also had genuine issues reported by this BCheck or have you only ever had false positives reported?

@Hannah-PortSwigger
Copy link
Contributor

Some improvements have been made to this BCheck - please let us know if you're still experiencing this issue.

@p80n-sec
Copy link
Contributor

p80n-sec commented Mar 7, 2024

Just looking at this fix. While addressing the false positives of static files, this fix does not detect the flaw in a large amount of cases now. It makes the assumption that base responses are not 200s. When initially finding this flaw a majority of cases started with base 200 responses. I will see if I can make some adjustments to account for static flaws besides just a 200 gate

@JaveleyQAQ
Copy link
Contributor Author

Just looking at this fix. While addressing the false positives of static files, this fix does not detect the flaw in a large amount of cases now. It makes the assumption that base responses are not 200s. When initially finding this flaw a majority of cases started with base 200 responses. I will see if I can make some adjustments to account for static flaws besides just a 200 gate

Static detection of defects is not your fault, scanner legacy problems. If you just rely on resp 200 to judge that the false positive is too high. Some dynamic pages are only used to record information. No matter what parameters the user submits, it only records and returns 200. This can lead to false positives. In short, I encountered a lot of different situations, so I chose not to enable this plug-in, so I have never tested it successfully.

@Michelle-PortSwigger
Copy link
Contributor

@p80n-sec Thanks for the feedback :)

BChecks are very much a community effort. We'd love to see what improvements you can make to this one. Once you've made your adjustments, please feel free to send a PR with them!

@PortSwiggerWiener
Copy link
Collaborator

Reopening until false negatives issue addressed.

@PortSwiggerWiener PortSwiggerWiener added the good first issue Good for newcomers label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers template Issue in BCheck template
Development

Successfully merging a pull request may close this issue.

5 participants