fix(clickhouse-operator): pin docker image version #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were using the latest available image. Here we pin to the latest image. It looks like they version the chart and the operator image the same. It may be worth pinning them to the same version. However, this will cause the operator to downgrade in existing installs, so here I'm opting to try to keep the image version the same as current installs.
|
I think you need to update the test snapshots but overall LGTM. Thank you! |
guidoiaquinti
approved these changes
May 10, 2022
added 2 commits
May 10, 2022 09:08
|
We probably forgot to bump the chart with this merge. No worries head over to https://github.com/PostHog/charts-clickhouse/actions/workflows/bump-version-workflow-dispatch.yaml to trigger the chart update. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were using the latest available image. Here we pin to the
latest image as of writing.
It looks like they version the chart and the operator image the same. It
may be worth pinning them to the same version. However, this will cause
the operator to downgrade in existing installs, so here I'm opting to
try to keep the image version the same as current installs.
Closes #370
Description
Type of change
How has this been tested?
Checklist