Support on feature flags loaded #111
Conversation
| @@ -53,6 +59,9 @@ class PosthogFlutterPlugin : FlutterPlugin, MethodCallHandler { | |||
| debug = enableDebug | |||
| sdkName = "posthog-flutter" | |||
| sdkVersion = postHogVersion | |||
| onFeatureFlags = PostHogOnFeatureFlags { | |||
There was a problem hiding this comment.
Using the callback is a good idea but it'd not work in some cases, for example
https://github.com/PostHog/posthog-android/blob/8013cccadfe52ad347eedcb492ce01690a1f7786/posthog/src/main/java/com/posthog/internal/PostHogFeatureFlags.kt#L40-L45
in this case, the callback will never be called, we'd need to either change the PostHogOnFeatureFlags interface which is a breaking change or find a way to expose the loaded flags differently (on the iOS and Android SDK)
| @@ -29,6 +33,8 @@ class PosthogFlutterPlugin : FlutterPlugin, MethodCallHandler { | |||
| channel.setMethodCallHandler(this) | |||
| } | |||
|
|
|||
| private val isLoaded = MutableStateFlow(false); | |||
There was a problem hiding this comment.
I'd not use coroutines but rather implement a dependency-free mechanism, there are a few days to do this.
| @@ -44,6 +47,9 @@ public class PosthogFlutterPlugin: NSObject, FlutterPlugin { | |||
| postHogSdkName = "posthog-flutter" | |||
| postHogVersion = postHogFlutterVersion | |||
|
|
|||
| NotificationCenter.default.addObserver(forName: PostHogSDK.didReceiveFeatureFlags, object: nil, queue: nil) { (notification) in | |||
There was a problem hiding this comment.
Similar to https://github.com/PostHog/posthog-flutter/pull/111/files#r1624601103
but in this case didReceiveFeatureFlags is called even if there's an error, we'd probably need something more so we know if feature flags are errored or not.
💡 Motivation and Context
Closes #81
💚 How did you test it?
📝 Checklist