Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a 10 second max timeout to flush requests #79

Open
benjackwhite opened this issue Dec 5, 2022 · 2 comments
Open

Add a 10 second max timeout to flush requests #79

benjackwhite opened this issue Dec 5, 2022 · 2 comments
Assignees

Comments

@benjackwhite
Copy link

When shutting down, users are advised to call .flush to ensure all queued events are sent. Without a timeout this can block the shutdown, causing other issues

@neilkakkar
Copy link
Collaborator

Neil to check if timeouts on requests are sufficient to not block thread joins

@neilkakkar neilkakkar reopened this Dec 5, 2022
@neilkakkar neilkakkar self-assigned this Dec 5, 2022
@0xRaduan
Copy link

0xRaduan commented Feb 3, 2024

How long does flush take in general? I just read about using it here, and I have a bunch of short-lived tasks in Celery. However, what I've noticed, is that after putting flush at the end of my celery task, it's blocked(for >10 minutes), and never actually finishes / nor sends then request.

For now I am using sync client, but I want to use async one, because otherwise I have celery tasks, which can produce a lot of events, and I don't want to use sync calls for that.

Please advise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants