Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: alias has user and previous swapped #22

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+15 −5
Open

fix: alias has user and previous swapped #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fbee0cb
fix: alias has user and previous swapped
oliverb123 Oct 23, 2024
0854bcc
Update test.js
oliverb123 Oct 23, 2024
d205ddc
fix
oliverb123 Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,16 @@ async function onTrack(event, settings) {
event.properties['$groups'] = { segment_group: event.context.groupId }
}

// In alias cases, we set the distinct id explicitly and it has to be what's expected. In all other
// cases, we use the userId if it exists, otherwise the anonymousId.
let distinct_id = null;

if (event.event === '$create_alias') {
distinct_id = event.properties.distinct_id;
} else {
distinct_id = event.userId || event.anonymousId;
}

const res = await fetch(endpoint, {
body: JSON.stringify({
uuid,
Expand All @@ -77,7 +87,7 @@ async function onTrack(event, settings) {
properties: {
...parseContext(event.context),
...event.properties,
distinct_id: event.userId || event.anonymousId,
distinct_id: distinct_id,
$lib: 'Segment',
},
}),
Expand Down Expand Up @@ -174,8 +184,8 @@ async function onAlias(event, settings) {
...event,
event: '$create_alias',
properties: {
alias: event.previousId,
distinct_id: event.userId,
alias: event.userId,
distinct_id: event.previousId,
},
},
settings
Expand Down
4 changes: 2 additions & 2 deletions test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,8 +270,8 @@ describe('Segment Integration', () => {
segment_ip: '8.8.8.8',
segment_userAgent:
'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/40.0.2214.115 Safari/537.36',
alias: '39239-239239-239239-23923',
distinct_id: '507f191e81',
alias: '507f191e81',
distinct_id: '39239-239239-239239-23923',
$lib: 'Segment',
},
})
Expand Down
Loading