fix: Simplify code for skip-typegen

Let's not pollute the base `turbo.json` file, and instead pollute the
package.json file because that's slightly better

Author: rafaeelaudibert

bin/start-frontend

@@ -9,10 +9,4 @@ set -e
 export DEBUG=0
 
 pnpm --filter=@posthog/frontend... install
-
-# Choose between start and start-no-typegen based on SKIP_TYPEGEN env variable
-if [ "${SKIP_TYPEGEN}" = "1" ]; then
-    bin/turbo --filter=@posthog/frontend start-no-typegen
-else
-    bin/turbo --filter=@posthog/frontend start
-fi
+bin/turbo --filter=@posthog/frontend start

frontend/package.json

@@ -23,8 +23,9 @@
         "build:esbuild": "DEBUG=0 node ./build.mjs",
         "build:tailwind": "pnpm --filter=@posthog/tailwind build",
         "watch:tailwind": "pnpm --filter=@posthog/tailwind start",
-        "start": "concurrently -n ESBUILD,TYPEGEN,TAILWIND -c yellow,green,blue \"pnpm start-http\" \"pnpm run typegen:watch\" \"sleep 40 && pnpm watch:tailwind\"",
-        "start-no-typegen": "concurrently -n ESBUILD,TAILWIND -c yellow,blue \"pnpm start-http\" \"sleep 40 && pnpm watch:tailwind\"",
+        "start": "if [ -n \"$SKIP_TYPEGEN\" ]; then pnpm start-no-typegen; else pnpm start-all; fi",
+        "start-all": "concurrently -n ESBUILD,TYPEGEN,TAILWIND -c yellow,green,blue \"pnpm start-http\" \"${SKIP_TYPEGEN:-pnpm run typegen:watch}\" \"sleep 40 && pnpm watch:tailwind\"",
+        "start-no-typegen": "concurrently -n ESBUILD,TAILWIND -c yellow,green,blue \"pnpm start-http\" \"sleep 40 && pnpm watch:tailwind\"",
         "start-http": "pnpm clean && pnpm copy-scripts && pnpm build:esbuild --dev",
         "start-docker": "pnpm start-http --host 0.0.0.0",
         "typegen:write": "cd .. && kea-typegen write --delete --show-ts-errors",

turbo.json

@@ -21,12 +21,8 @@
         "start": {
             "dependsOn": ["^build"],
             "persistent": true,
-            "cache": false
-        },
-        "start-no-typegen": {
-            "dependsOn": ["^build"],
-            "persistent": true,
-            "cache": false
+            "cache": false,
+            "passThroughEnv": ["SKIP_TYPEGEN"]
         },
         "dev": {
             "dependsOn": ["^build"],