Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set/Add/New secret should be separate cmdlets #218

Open
dbramblett opened this issue Feb 14, 2024 · 1 comment
Open

Set/Add/New secret should be separate cmdlets #218

dbramblett opened this issue Feb 14, 2024 · 1 comment
Labels
question Further information is requested

Comments

@dbramblett
Copy link

Summary of the new feature / enhancement

The use of 'Set' instead of 'New' for the verb to create a secret doesn't seem intuitive to me, at least in the context of the descriptions provided by Get-Verb.

'New' creates a resource,
'Add' Adds a resource to a container or attaches an item to another item.
'Set' replaces data or creates a resource.

It seems to me that 'Set-Secret' here is combining all three verbs under the aegis of one verb.

If it were me, I'd look for the following.
'New-Secret' to create the secret,
'Add-Secret' to add it to the store.
'Set-Secret' to alter an existing secret.

These would make more sense to me than having a single cmdlet to do all three. 'Add-Secret' also auto-implies a 'Remove-Secret' and vice versa.

Proposed technical implementation details (optional)

No response

@SydneyhSmith SydneyhSmith added the question Further information is requested label Feb 26, 2024
@OtterKring
Copy link

I would like to add to this asking for Set-Secret to NOT remove the metadata of an existing secret. It should really only set a new secret value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants