Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Multiple instances of SecretStore #58

Open
jdhitsolutions opened this issue Apr 16, 2021 · 15 comments
Open

Request: Multiple instances of SecretStore #58

jdhitsolutions opened this issue Apr 16, 2021 · 15 comments
Labels
enhancement New feature or request

Comments

@jdhitsolutions
Copy link

I don't know if this is a documentation issue or a bug, so I'll ask. I have a vault registered using Microsoft.PowerShell.SecretStore. I then tried to create a second vault.

 Register-SecretVault -Name demo -Description "test vault" -ModuleName microsoft.powershell.secretstore

Get-SecretVault shows it. I have nothing in the vault but if I run Get-SecretInfo, I see all the entries from my default vault, even though the vault name shows the new demo vault. Are we limited to one vault per user of a given module? If so, that needs to be clearer in the documentation.

@jdhitsolutions
Copy link
Author

Clearly, there is some sort of interaction happening.

image

@PaulHigin
Copy link
Contributor

SecretManagement allows an extension vault to be registered multiple times, because it is possible that an extension vault may support different contexts via the registration VaultParameters. However, the SecretStore vault currently always operates in the logged on user scope (see SecretStore documentation: https://github.com/powershell/secretstore).

So registering SecretStore multiple times with different names just results in duplication of the same store, and doesn't make sense.
But we decided to allow this for maximum flexibility.

@jdhitsolutions
Copy link
Author

Ok then. Again, it would help to have this clearer in the documentation. The bottom line is that a user can only have 1 microsoft.powershell.secretstore vault per user scope. That's too bad because I can imagine a situation where I might want 2 stores based on the default Microsoft.PowerShell.SecretStore. Or are you expecting that people will really be using an extension vault like LastPass?

@SydneyhSmith
Copy link
Collaborator

Thanks @jdhitsolutions I'd love to better understand why a user may want multiple SecretStore instances in a particular user scope, does having secretmetadata help users to organize their secrets in a way that doesnt require a second instance of the store?

Agree that we can make this more clear in the SecretStore documentation

@jdhitsolutions
Copy link
Author

I might want one store with data that is associated with a module or CI/CD project I'm running and a second store for personal items. I might want one group of data to have a longer unlock time and another set to be more secure. A single store means every secret is treated the same and maybe that isn't what I want.

@SydneyhSmith SydneyhSmith transferred this issue from PowerShell/SecretManagement Apr 26, 2021
@SydneyhSmith SydneyhSmith changed the title Are multiple vaults allowed? Request: Multiple instances of SecretStore Apr 26, 2021
@SydneyhSmith SydneyhSmith added the enhancement New feature or request label Apr 26, 2021
@PetriAsi
Copy link

I have same king of needs with @jdhitsolutions . Also custom or third party modules will benefit if secretstore can be register multiple times with different names and instances. Then custom module can create it's own store for it's secrets.

@SjoerdV
Copy link

SjoerdV commented Oct 31, 2021

Really need this as well. The use case is:

@craibuc
Copy link

craibuc commented Nov 28, 2022

I'd like to have multiple Microsoft.PowerShell.SecretStore SecretStores to segment secrets between clients.

@PaulHigin
Copy link
Contributor

PaulHigin commented Nov 28, 2022

Sounds like there is a need for multiple store instances. Adding PS-Committee review for visibility.

/cc: @SteveL-MSFT, @SydneyhSmith

@craibuc
Copy link

craibuc commented Nov 29, 2022

Is there a way to create independent, Microsoft.PowerShell.SecretStore instances by supplying values to -VaultParameters?

@ckolumbus
Copy link

@PaulHigin this topic seems to be stale for a while again, but I need exactly the same functionality. So a +1 for this topic from my side.

@Admiral-AI
Copy link

+1 would like this feature if possible to implement

@Pseudolegend
Copy link

I would also find this feature useful.

@lastphoenx
Copy link

I would also find this feature extremly useful. I totally agree with the uses-cases mentionned before.

@ArieHein
Copy link

ArieHein commented Sep 7, 2024

I wanted to create two vaults based on SecretStore, per environment :

register-SecretVault -name SecretStoreDev -ModuleName Microsoft.PowerShell.SecretStore -Description "Dev Vault"
register-SecretVault -name SecretStoreProd -ModuleName Microsoft.PowerShell.SecretStore -Description "Prod Vault"

But its not enough to be able to have them, they need to be separated when you use Get-SecretStoreConfiguration
and when you use Set-SecretStoreConfiguration as i would like differernt passwords for each and locking behavior as example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests