Add support for case sensitive schema name #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Praveen2112
force-pushed
the
praveen/080_1/case_sensitive_support_for_schema
branch
12 times, most recently
from
71a603a to
f3578a3
Compare
kokosing
reviewed
May 4, 2021
| * Canonicalizes the provided SQL identifier according to connector-specific rules | ||
| * for the purpose of providing the name in metadata APIs | ||
| */ | ||
| default String canonicalize(ConnectorSession session, String identifier, boolean delimited) |
There was a problem hiding this comment.
If some connector wants to maintain the legacy way of matching ... then they can use this to toggle between the legacy and actual way.
Praveen2112
force-pushed
the
praveen/080_1/case_sensitive_support_for_schema
branch
from
f3578a3 to
f5fb59a
Compare
We reference an version of the library. Removing on the assumption it's not actually needed.
A widely applied usecase for minhash algorithm is to check the similarity of two texts. Therefore the current implementation adds support for creating a `setdigest` aggregation for (among other types) varchar slices.
The previous catching of `RuntimeException` could mask implementation issues such as `VerifyException` or `NullPointerException`.
- process Optional fluently - group variable initialization
Praveen2112
force-pushed
the
praveen/080_1/case_sensitive_support_for_schema
branch
from
f5fb59a to
c2be62e
Compare
These will be enforced by the query engine and by the connector.
Supports create/rename/drop schema. But using it as a part of table name or column name is restricted. However we can specify it via `USE` or specify them in session
Praveen2112
force-pushed
the
praveen/080_1/case_sensitive_support_for_schema
branch
from
c2be62e to
3f59a8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.