Skip to content

Commit 537d8b8

Browse files
authoredMar 24, 2024··
fix: category update 에러 & group user 검색 예외 처리 (#158)
2 parents db1e2e2 + 6b77385 commit 537d8b8

File tree

5 files changed

+15
-10
lines changed

5 files changed

+15
-10
lines changed
 

‎src/main/java/com/uspray/uspray/controller/GroupController.java

+2-1
Original file line numberDiff line numberDiff line change
@@ -169,9 +169,10 @@ public ApiResponseDto<?> deleteGroup(
169169
@GetMapping("/{groupId}/member/search")
170170
public ApiResponseDto<List<GroupMemberResponseDto>> searchGroupMembers(
171171
@PathVariable Long groupId,
172+
@Parameter(hidden = true) @AuthenticationPrincipal User user,
172173
@RequestParam(required = false) String name) {
173174
return ApiResponseDto.success(SuccessStatus.GET_MEMBER_LIST_SUCCESS,
174-
groupService.searchGroupMembers(groupId, name));
175+
groupService.searchGroupMembers(groupId, name, user.getUsername()));
175176
}
176177

177178
@Operation(summary = "그룹 알림 설정")

‎src/main/java/com/uspray/uspray/infrastructure/querydsl/group/GroupRepositoryCustom.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,13 @@
22

33
import com.uspray.uspray.DTO.group.response.GroupMemberResponseDto;
44
import com.uspray.uspray.DTO.group.response.GroupResponseDto;
5-
65
import java.util.List;
76

87
public interface GroupRepositoryCustom {
98

109
List<GroupResponseDto> findGroupListByMemberId(String userId);
1110

12-
List<GroupMemberResponseDto> findGroupMembersByGroupAndNameLike(Long groupId, String name);
11+
List<GroupMemberResponseDto> findGroupMembersByGroupAndNameLikeExceptUser(Long groupId,
12+
String name, String username);
1313

1414
}

‎src/main/java/com/uspray/uspray/infrastructure/querydsl/group/GroupRepositoryImpl.java

+3-2
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,8 @@ public List<GroupResponseDto> findGroupListByMemberId(String userId) {
4545
}
4646

4747
@Override
48-
public List<GroupMemberResponseDto> findGroupMembersByGroupAndNameLike(Long groupId,
49-
String name) {
48+
public List<GroupMemberResponseDto> findGroupMembersByGroupAndNameLikeExceptUser(Long groupId,
49+
String name, String username) {
5050

5151
BooleanBuilder builder = new BooleanBuilder();
5252

@@ -65,6 +65,7 @@ public List<GroupMemberResponseDto> findGroupMembersByGroupAndNameLike(Long grou
6565
.from(member)
6666
.join(member.groupMemberList, groupMember)
6767
.where(builder)
68+
.where(member.userId.ne(username))
6869
.fetch();
6970
}
7071

‎src/main/java/com/uspray/uspray/service/CategoryService.java

+4-2
Original file line numberDiff line numberDiff line change
@@ -89,8 +89,10 @@ public CategoryResponseDto updateCategory(String username, Long categoryId,
8989
CategoryRequestDto categoryRequestDto) {
9090
Category category = categoryRepository.getCategoryByIdAndMember(categoryId,
9191
memberRepository.getMemberByUserId(username));
92-
categoryRepository.checkDuplicate(categoryRequestDto.getName(), category.getMember(),
93-
CategoryType.valueOf(categoryRequestDto.getType().toUpperCase()));
92+
if (categoryRequestDto.getName() != null) {
93+
categoryRepository.checkDuplicate(categoryRequestDto.getName(), category.getMember(),
94+
CategoryType.valueOf(categoryRequestDto.getType().toUpperCase()));
95+
}
9496
category.update(categoryRequestDto);
9597
return CategoryResponseDto.of(category);
9698
}

‎src/main/java/com/uspray/uspray/service/GroupService.java

+4-3
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,10 @@ public GroupListResponseDto getGroupList(String username) {
3434
}
3535

3636
@Transactional(readOnly = true)
37-
public List<GroupMemberResponseDto> searchGroupMembers(Long groupId, String name) {
38-
List<GroupMemberResponseDto> groupMemberResponseDtoList = groupRepository.findGroupMembersByGroupAndNameLike(
39-
groupId, name);
37+
public List<GroupMemberResponseDto> searchGroupMembers(Long groupId, String targetName,
38+
String username) {
39+
List<GroupMemberResponseDto> groupMemberResponseDtoList = groupRepository.findGroupMembersByGroupAndNameLikeExceptUser(
40+
groupId, targetName, username);
4041
for (GroupMemberResponseDto dto : groupMemberResponseDtoList) {
4142
dto.setUserId(MaskingUtil.maskUserId(dto.getUserId()));
4243
}

0 commit comments

Comments
 (0)
Please sign in to comment.