-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generify Repository Name #11
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I'm really sorry that I wasn't able to attend to this issue. I agree that most of the traffic comes from Google searches and just renaming should maintain the traffic. However, I think I'll rename it when I've added a bit more features to the module and post it like a new release. And hence, please keep opening issues for new features. Currently, I'm a little busy but I assure you I'll get back to this issue soon. |
No Problem. We all have limited time for this (sadly) |
I have been using a modified version of this repo in such a way that it's not specific to spotify. It assumes However, there's a bug to which I haven't been able to figure out a solution: Steps to reproduce
Expected behavior
Actual behavior
I tried to fix this by using |
@fuadsaud Can you please open a separate issue? |
@fuadsaud @PrayagS any update on this? would love to make this module as part of my dotfiles generator once it supports more than spotify 😸 |
When looking for a Polybar plugin to control music playback in chrome with, I scrolled across this multiple times without opening it. The naming suggests that this only works with Spotify, while your code actually is quite generic.
Wouldn't it be good to change the repository name to something like
polybar-playerctl
? Furthermore, the names of example modules in the readme (and in the hooks inget_spotify_status.sh
) would need to be updated.Edit: Just noticed you mentioned this in one of your commits. I think you should :)
The text was updated successfully, but these errors were encountered: