Adding prints that show the field names being compared
#24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because we loop over field names _within_ tests, rather than as pytest fixtures, we don't know which field may have caused a failure. These `print`s will help for triaging compatibility issues.
serinamarie
approved these changes
May 30, 2024
test_oss_cloud_api_compatibility.py
Outdated
| @@ -382,6 +386,10 @@ def preprocess_pydantic_v1_type(schema): | |||
| ] | |||
|
|
|||
| for field_name, props in items: | |||
| # Note, this print is here intentionally to make it easier to understand | |||
| # test failures when looping over fields | |||
| print(field_name) | |||
There was a problem hiding this comment.
nit: Does it make sense to print that this is a field name as well or would that already be apparent?
e.g. print(f"field name: {field_name}")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we loop over field names within tests, rather than as pytest fixtures,
we don't know which field may have caused a failure. These
prints will helpfor triaging compatibility issues.