Enhancement: Use bottom placement for flow run scatter plot popover #1559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for prefect-ui-library ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
|
||
| .flow-run-pop-over__content { @apply | ||
| p-2 | ||
| pointer-events-none |
There was a problem hiding this comment.
Won't this prevent interacting with the contents of the popover? So I wouldn't be able to hover a point and then go to the run associated with it?
There was a problem hiding this comment.
hmm I feel like you are correct, I wanted to add some spacing between the trigger and the content but not have it as part of the interaction. But I think you're right this will cascade to the content itself. I'll double check
|
@pleek91 - shall we close this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where horizontally scrubbing through flow runs was difficult due to the popover appearing directly to the right of the flow run point on the chart.
Closes #1460
Also removed the custom logic for closing the popover in favor of the built in functionality which didn't exist when this component was first created.
Also added a big a padding between the popover and the flow run point so even if the popover opens in the direction of the next point if they are right next to each other the next point should be visible.