Skip to content

Commit 7f44dfc

Browse files
authored
Merge pull request #9 from Preliy/development
Development
2 parents 3a35836 + ce20c50 commit 7f44dfc

File tree

2 files changed

+26
-5
lines changed

2 files changed

+26
-5
lines changed

Runtime/Scripts/Kinematic/FrameConfig.cs

+11-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
namespace Preliy.Flange
44
{
55
/// <summary>
6-
/// DenavitHartenberg frame configuration
6+
/// Frame configuration using the Denavit-Hartenberg parameters
77
/// </summary>
88
[System.Serializable]
99
public record FrameConfig
@@ -24,14 +24,24 @@ public string Name
2424
[Tooltip("Alpha [rad]")]
2525
[SerializeField]
2626
private float _alpha;
27+
[Tooltip("A [m]")]
2728
[SerializeField]
2829
private float _a;
30+
[Tooltip("D [m]")]
2931
[SerializeField]
3032
private float _d;
3133
[Tooltip("Theta [rad]")]
3234
[SerializeField]
3335
private float _theta;
3436

37+
/// <summary>
38+
/// Initializes a new instance of the <see cref="FrameConfig"/> class using the Denavit-Hartenberg parameters
39+
/// </summary>
40+
/// <param name="alpha">The link twist (α) [rad], representing the angle between the z-axes of consecutive frames.</param>
41+
/// <param name="a">The link length (a) [m], which is the distance between the z-axes along the common normal.</param>
42+
/// <param name="d">The link offset (d) [m], the distance along the previous z-axis to the common normal.</param>
43+
/// <param name="theta">The joint angle (θ) [rad], the rotation about the previous z-axis to align the x-axes.</param>
44+
/// <param name="name">An optional identifier for the frame configuration.</param>
3545
public FrameConfig(float alpha, float a, float d, float theta, string name = null)
3646
{
3747
_name = name;

Runtime/Scripts/Kinematic/JointConfig.cs

+15-4
Original file line numberDiff line numberDiff line change
@@ -22,20 +22,31 @@ public string Name
2222
private string _name;
2323
[SerializeField]
2424
private TransformJoint.JointType _type;
25+
[Tooltip("Limits [deg] or [m]")]
2526
[SerializeField]
2627
private Vector2 _limits;
27-
[Tooltip("Offset [deg]")]
28+
[Tooltip("Offset [deg] or [m]")]
2829
[SerializeField]
2930
private float _offset;
3031
[SerializeField]
3132
private float _factor;
32-
[Tooltip("Speed max [deg/s]")]
33+
[Tooltip("Speed max [deg/s] or [m/s]")]
3334
[SerializeField]
3435
private float _speedMax;
35-
[Tooltip("Acc max [deg/s^2]")]
36+
[Tooltip("Acc max [deg/s^2] or [m/s^2]")]
3637
[SerializeField]
3738
private float _accMax;
38-
39+
40+
/// <summary>
41+
/// Initializes a new instance of the <see cref="JointConfig"/> class with the specified joint configuration parameters.
42+
/// </summary>
43+
/// <param name="type">The type of the transform joint (e.g., revolute or prismatic).</param>
44+
/// <param name="limits">The joint limits as a <see cref="Vector2"/>, representing the minimum and maximum values in [deg] or [m].</param>
45+
/// <param name="offset">The offset value for the joint, specified in [deg] or [m].</param>
46+
/// <param name="factor">A scaling factor applied to the joint’s configuration.</param>
47+
/// <param name="speedMax">The maximum speed of the joint in [deg/s] or [m/s].</param>
48+
/// <param name="accMax">The maximum acceleration of the joint in [deg/s^2] or [m/s^2].</param>
49+
/// <param name="name">An optional identifier for the joint configuration.</param>
3950
public JointConfig(TransformJoint.JointType type, Vector2 limits, float offset, float factor, float speedMax, float accMax, string name = null)
4051
{
4152
_name = name;

0 commit comments

Comments
 (0)