Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unguarded usage of eigen in kokkos test #22

Closed
pierrepebay opened this issue Nov 8, 2024 · 0 comments · Fixed by #24
Closed

Unguarded usage of eigen in kokkos test #22

pierrepebay opened this issue Nov 8, 2024 · 0 comments · Fixed by #24

Comments

@pierrepebay
Copy link
Collaborator

pierrepebay commented Nov 8, 2024 •
edited
Loading

In tests/ops/ops_kokkos_diag.cc, there are two uses of an Eigen::VectorXd even if PRESSIO_ENABLE_TPL_EIGEN is off. This causes a problem when building with kokkos on but eigen off.

pressio-ops/tests/ops/ops_kokkos_diag.cc

Line 176 in e5d5e14

Eigen::VectorXd gold(5);

pressio-ops/tests/ops/ops_kokkos_diag.cc

Line 239 in e5d5e14

Eigen::VectorXd gold(5);

@fnrizzi fnrizzi linked a pull request Nov 10, 2024 that will close this issue
Issue22 #24
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue22 Pressio/pressio-ops
1 participant
@pierrepebay