Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storing private key (nsec) without encryption in local storage may be a security risk #99

Open
cfahrenholz opened this issue Sep 12, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@cfahrenholz
Copy link

Describe the Bug

I attempted to review how the private key is stored locally. From what I could see, it is stored without encryption. This poses a potential security risk if someone gains access to the device and can read or copy the values from local storage.

Expected Behavior

Please consider encrypting the private key provided by the user, for example, using react-secure-storage.

This site also explains the potential security risks involved.

If I have not investigated the code correctly, I apologize in advance.

@cfahrenholz cfahrenholz added the bug Something isn't working label Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant