Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social logins crash when not configured #945

Open
4 tasks done
nikolay-vasilev-prime opened this issue Jan 3, 2025 · 2 comments
Open
4 tasks done

Social logins crash when not configured #945

nikolay-vasilev-prime opened this issue Jan 3, 2025 · 2 comments
Assignees

Comments

@nikolay-vasilev-prime
Copy link
Contributor

nikolay-vasilev-prime commented Jan 3, 2025

EDIT: The crash was due to missing keys in .plist files and since we don't want to add them in the cli project, they were addressed only in the liquidtools showcase project and aren't part of the cli.

As a user I would like when social logins aren't configured to see error message instead of a crash.

ACs:

  • Handle facebook login error state.
  • Handle Google login error state.
  • Show bottom sheet error message for facebook login.
  • Show bottom sheet error message for Google login.
@nikolay-vasilev-prime nikolay-vasilev-prime self-assigned this Jan 3, 2025
@nikolay-vasilev-prime nikolay-vasilev-prime converted this from a draft issue Jan 3, 2025
@StanevPrime StanevPrime moved this to To Do in rx_bloc_cli Jan 3, 2025
@nikolay-vasilev-prime nikolay-vasilev-prime moved this from To Do to In Progress in rx_bloc_cli Jan 3, 2025
@nikolay-vasilev-prime
Copy link
Contributor Author

The app crashes with an error that cannot be handled on iOS, if the info.plist keys are missing.
The solution is to add the required keys and leave the values for the developer to set them.

The crash may be introduced again when facebook or google auth packages are updated and the new implementation requires different keys.

@nikolay-vasilev-prime nikolay-vasilev-prime moved this from In Progress to Merged in rx_bloc_cli Jan 6, 2025
@GoranPrime GoranPrime self-assigned this Jan 10, 2025
@GoranPrime GoranPrime moved this from Merged to Tested in rx_bloc_cli Jan 10, 2025
@GoranPrime
Copy link
Contributor

Tested & working as intended (shows appropriate errors, no crashes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Tested
Development

No branches or pull requests

3 participants