Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements the tags with dimensions #215

Merged
merged 9 commits into from
Dec 3, 2024
Merged

Implements the tags with dimensions #215

merged 9 commits into from
Dec 3, 2024

Conversation

lsawade
Copy link
Collaborator

@lsawade lsawade commented Dec 2, 2024

Description

Adds dimension to the tags struct.

Issue Number

Closes #206

Checklist

Please make sure to check developer documentation on specfem docs.

  • I ran the code through pre-commit to check style
  • My code passes all the integration tests
  • I have added sufficient unittests to test my changes
  • I have added/updated documentation for the changes I am proposing
  • I have updated CMakeLists to ensure my code builds
  • My code builds across all platforms

@lsawade lsawade changed the title 206 Implements the tags with dimensions Dec 2, 2024
@lsawade lsawade changed the base branch from main to devel December 2, 2024 22:43
Copy link
Collaborator

@Rohit-Kakodkar Rohit-Kakodkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Rohit-Kakodkar Rohit-Kakodkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The merge branch need to change from devel to issue-200

@lsawade lsawade changed the base branch from devel to issue-200 December 3, 2024 16:01
Copy link
Collaborator

@Rohit-Kakodkar Rohit-Kakodkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lsawade lsawade merged commit 95a9f0d into issue-200 Dec 3, 2024
3 of 6 checks passed
@lsawade lsawade deleted the 206 branch December 10, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants