Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Downgrade InvokeAction method of class EventSubscription access from public to protected #3284

Open
BruceLeeCorner opened this issue Nov 25, 2024 · 0 comments

Comments

@BruceLeeCorner
Copy link

Summary

I figure , it is better to downgrade access of InvokeAction method in class EventSubscription from public to protected.

API Changes

Just change 3 files EventSubscription.cs DispatcherEventSubscription.cs BackgroundEventSubscription.cs.

e.g.

change

public virtual void InvokeAction(Action action)
{
    if (action == null) throw new ArgumentNullException(nameof(action));

    action();
}

to

protected virtual void InvokeAction(Action action)
{
    if (action == null) throw new ArgumentNullException(nameof(action));

    action();
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant