Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a method downloading resources at runtime #38

Open
TheDudeFromCI opened this issue Aug 10, 2020 · 4 comments
Open

Implement a method downloading resources at runtime #38

TheDudeFromCI opened this issue Aug 10, 2020 · 4 comments

Comments

@TheDudeFromCI
Copy link
Member

As the scale of Minecraft-Data increases, this can add unneeded size to the node_modules. It would be more efficient to download the required resources as needed at runtime.

This might be done via git, or curl'ing the raw github repo. This data can be cached for future runs, if desired.

@rom1504
Copy link
Member

rom1504 commented Sep 4, 2020

this should happen at the very beginning (at import time) and be sync.

if anyone wants to make a module for this, feel free. (probably a node-minecraft-data-dynamic repo)

@rom1504
Copy link
Member

rom1504 commented Sep 4, 2020

actually the whole thing compressed is 2.5MB, I'm not sure if there is any use case here

@rom1504
Copy link
Member

rom1504 commented Sep 4, 2020

the only thing that could be done to make it faster to download would be to provide .tgz with preinstalled prismarinejs libs

@rom1504
Copy link
Member

rom1504 commented Oct 6, 2020

maybe downloading the tgz from mcdata tag + https://github.com/nika-begiashvili/libarchivejs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants