-
-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix serialization issue in old version for mc server test #1337
Comments
fyi @extremeheat |
I think this is likely caused by recent node protodef changes https://github.com/ProtoDef-io/node-protodef/commits/master/ |
Only change in ProtoDef was how the compiler inlined anonymous containers (treats them as normal containers then merges object into parent), so I don't think it would affect anything big. Would need to see what packet specifically is causing the error and the dumped buffer to reproduce (the stack trace here is limited to only a few lines it seems) |
ProtoDef-io/node-protodef@fcf3ca0 was also recently released |
PrismarineJS/mineflayer#3492 mentions packet advancement |
For 1.21 wonder if it could be https://github.com/PrismarineJS/node-minecraft-protocol/blob/master/src/datatypes/compiler-minecraft.js#L44 |
kicks clients when invalid credentials:
Uncaught RangeError [ERR_OUT_OF_RANGE]: The value of "offset" is out of range. It must be >= 0 and <= 45. Received -847077210
at new NodeError (node:internal/errors:405:5)
at boundsError (node:internal/buffer:88:9)
at Buffer.readUInt8 (node:internal/buffer:254:5)
at readVarInt (node_modules/protodef/src/datatypes/utils.js:68:22)
at Splitter._transform (src/transforms/framing.js:63:30)
at Transform._write (node_modules/readable-stream/lib/internal/streams/transform.js:153:8)
The text was updated successfully, but these errors were encountered: