node-minecraft-protocol can throw an unhandled exception when the returned disconnect string is invalid.

[IceTank]

[x] The FAQ doesn't contain a resolution to my issue

Versions

• minecraft-protocol: lastest
• server: vanilla/spigot/paper not vanilla ?
• node: 14

Detailed description of a problem

This line in node-minecraft-protocol can throw an unhandled error when the returned string is not a json or invalid.

node-minecraft-protocol/src/client/versionChecking.js

Line 4 in ffe912b

const parsed = JSON.parse(message.reason)

Expected behavior

Better error handling. Maybe emit the raw string instead when the json parsing failed.

[kashalls]

The only thing I can think of without figuring out if this is a client problem or server problem, is to do something like:

module.exports = function (client, options) {
  client.on('disconnect', message => {
    if (!message.reason) return;
    let parsed;
    try {
        parsed = JSON.parse(message.reason)
    } catch {
        debug(`Failed to parse disconnect message: ${message}`);
        return;

But the rest of this file pretty much depends on parsing the reason.