-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
import all good changes from zardoy fork #420
Comments
first thing is migrating to esbuild to speed up builds by a lot |
btw just asking, would it be possible to implement changelogging in github releases like in repo mentioned above? like reading them github releases from mobile |
Yes but also include it into release body as text |
could be implemented by changing https://github.com/PrismarineJS/prismarine-template/blob/master/.github/workflows/publish.yml and https://github.com/PrismarineJS/prismarine-repo-actions but I don't really see a lot of point to it, history.md works well |
ok thanks, I want to adopt this idea, should be cool: https://github.com/evanw/esbuild/blob/main/.github/workflows/release.yml |
Could be done with a script in the repo to read the README.md / HISTORY.md and pipe to the release action's body. Or just adding a link to the HISTORY.md or README.md's changelog section could work too. |
yeah that's more or less what https://github.com/evanw/esbuild/blob/main/.github/workflows/release.yml#L20 do feel free to try adapting that to our https://github.com/PrismarineJS/prismarine-template/blob/master/.github/workflows/publish.yml @zardoy |
@zardoy has funded $10.00 to this issue.
|
https://github.com/zardoy/prismarine-web-client/commits/main/prismarine-viewer
The text was updated successfully, but these errors were encountered: