Skip to content

Commit 19db3c5

Browse files
committed
When checking if npm list command succeeds, catch any exception that's thrown
1 parent 74cd603 commit 19db3c5

File tree

1 file changed

+18
-10
lines changed

1 file changed

+18
-10
lines changed

src/CodeUpdater/CodeUpdater/PreRunValidator.cs

Lines changed: 18 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -54,21 +54,29 @@ private async ValueTask<bool> CanCheckNpmUpdatesAsync()
5454
return false;
5555
}
5656

57-
using var jsonDoc = JsonDocument.Parse(commandResult.Output);
58-
59-
if (!jsonDoc.RootElement.TryGetProperty("dependencies", out var dependenciesElement))
57+
try
6058
{
61-
Logger.Error($"`npm list` command is missing the `dependencies` element. Cannot verify the `npm-check-updates` package is installed");
62-
return false;
63-
}
59+
using var jsonDoc = JsonDocument.Parse(commandResult.Output);
60+
61+
if (!jsonDoc.RootElement.TryGetProperty("dependencies", out var dependenciesElement))
62+
{
63+
Logger.Error($"`npm list` command is missing the `dependencies` element. Cannot verify the `npm-check-updates` package is installed");
64+
return false;
65+
}
6466

65-
if (!dependenciesElement.TryGetProperty("npm-check-updates", out var npmCheckUpdatesElement))
67+
if (!dependenciesElement.TryGetProperty("npm-check-updates", out var npmCheckUpdatesElement))
68+
{
69+
Logger.Error($"`npm list` command is missing the `npm-check-updates` element, meaning that package is not installed. Before continuing, install that package by running `npm install -g npm-check-updates`.");
70+
return false;
71+
}
72+
73+
return true;
74+
}
75+
catch (Exception ex)
6676
{
67-
Logger.Error($"`npm list` command is missing the `npm-check-updates` element, meaning that package is not installed. Before continuing, install that package by running `npm install -g npm-check-updates`.");
77+
Logger.Error($"`npm list` command failed. Cannot verify the `npm-check-updates` package is installed. Error is: {ex.ToString()}");
6878
return false;
6979
}
70-
71-
return true;
7280
}
7381

7482
public class NpmPackagesListDto

0 commit comments

Comments
 (0)