Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix turning tolerance on escaping cone and recovering #38

Open
merose opened this issue Apr 19, 2018 · 0 comments
Open

Fix turning tolerance on escaping cone and recovering #38

merose opened this issue Apr 19, 2018 · 0 comments
Assignees
Labels

Comments

@merose
Copy link
Contributor

merose commented Apr 19, 2018

Currently the turning code depends on an angle tolerance. This is problematic because the rate at which we get robot state updates is only about 4Hz, and we may pass through the angle tolerance between updates. Instead, we should turn until the total turning exceeds a desired value. (Could exceed the value positively, for counter-clockwise turning, or negatively, for clockwise turning.)

This change will eliminate the need for an angle tolerance, so long as the desired turning is far enough away from 360 deg (= 0 deg) that we don't wrap around. Testing on 04-20 shows that an angle tolerance of +/- 30 deg works OK with the current code, so desired turning anywhere from 0-330 deg should work OK, and we'll probably never use more than 180 deg of desired turning.

@merose merose self-assigned this Apr 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant