Skip to content
This repository has been archived by the owner on Mar 25, 2023. It is now read-only.

Filter by language #155

Open
knjk04 opened this issue Mar 20, 2022 · 2 comments
Open

Filter by language #155

knjk04 opened this issue Mar 20, 2022 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers graphql

Comments

@knjk04
Copy link
Member

knjk04 commented Mar 20, 2022

Is your feature request related to a problem? If so, please describe.
A user may only want to see their books in their chosen language (e.g. Spanish). Currently, we'd show all books that satisfy the query, regardless of the language.

Describe the solution you'd like
For every GraphQL query, we should have an optional language argument.

Possible approaches:

  • filter the result set
  • define a custom query

Additional context

  • Be sure to read the contributing guidelines first!
  • Discuss your implementation approach with us before we assign you to it
  • Provide us with an estimate on how long you think it will take you to complete
  • Branch from main and set main as the destination branch in your pull request

If you need help with anything, we'll be happy to help you over a GitHub Q&A discussion or our Slack workspace

@knjk04 knjk04 added enhancement New feature or request good first issue Good for newcomers graphql labels Mar 20, 2022
@gstamatiadis
Copy link

Hello. Could I do this task? I have read the contributing guidelines. I think it will take about one week. My approach would be to write the appropriate query and the corresponding data fetcher.

@acyuta1
Copy link

acyuta1 commented May 30, 2022

Hey Karan @knjk04,

I can take this up.
Should be a straightforward one.

Approach:

  1. Request would contain an optional 'lang' param.
  2. I feel, filtering the result set is a better option since a where clause in a query seems unnecessary.

Please let me know if this looks okay! Looking forward to your reply.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers graphql
Projects
None yet
Development

No branches or pull requests

3 participants