Skip to content
This repository has been archived by the owner on Mar 25, 2023. It is now read-only.

Store the year a book won an award #158

Open
knjk04 opened this issue Mar 20, 2022 · 4 comments
Open

Store the year a book won an award #158

knjk04 opened this issue Mar 20, 2022 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@knjk04
Copy link
Member

knjk04 commented Mar 20, 2022

Describe the solution you'd like
If a book wins an award, we should be able to show the year it won that award

Additional context

  • Be sure to read the contributing guidelines first!
  • Discuss your implementation approach with us before we assign you to it
  • Provide us with an estimate on how long you think it will take you to complete
  • Branch from main and set main as the destination branch in your pull request

If you need help with anything, we'll be happy to help you over a GitHub Q&A discussion or our Slack workspace

@knjk04 knjk04 added enhancement New feature or request good first issue Good for newcomers labels Mar 20, 2022
@emsnguyen
Copy link

Hi Karan
I am a newbie to open source and I find your project interesting so I would like to be a part.
Below are what I am thinking about the problem you are having, I look forward to your reply.

  1. Implementation approach
    Input: Id of a particular book
    Output: the award name and the year the book won that award. Since a book can win many awards, the response should be a list I guess. If no award is found for the book, return an empty list.

I intend to select the awards associated with the book id via the book_award table, then refers to award table to get the award name and year.
I have one question, though. Is the "year" column in the award table means the year a book wins that award (which means that award is fixed to one particular year)? If not, I intend to add a "winning_year" property to the book_award table.

  1. Estimate: 10 hours of coding and testing (this is my first time with open source so I am not quite sure, but I will do my best to finish this by the end of this week (April 24th 2022)

@ddninja
Copy link

ddninja commented Oct 2, 2022

hi @knjk04 , is this issue still open?

@ShubhraSuman
Copy link

Can you assign this to me?

@sushmitha-malae
Copy link

Interested in contributing to this issue, can you assign to me.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants