Replies: 5 comments
-
Hi @wyli, |
Beta Was this translation helpful? Give feedback.
-
yes, it is, please feel free to create PRs (there's a |
Beta Was this translation helpful? Give feedback.
-
@wyli I was planning to have my team work on some of this as we work through using MONAI on our projects. It is a next item after type hinting is in better shape. |
Beta Was this translation helpful? Give feedback.
-
@benjamin-gorman @crtrentz Please keep an eye on this issue, you will be asked to contribute to this effort later this summer. |
Beta Was this translation helpful? Give feedback.
-
this is a general proposal and has been implemented for many components, I'm converting it to the discussions |
Beta Was this translation helpful? Give feedback.
-
most pytorch modules come with nice examples in the docstring. for example, the docstring of
torch.nn.modules.Conv1d
has this block:these are also available in the autogenerated documentation site:
MONAI's modules should also include such intuitive examples.
(currently It's been done for only a few classes, e.g.:
https://github.com/Project-MONAI/MONAI/blob/master/monai/transforms/croppad/array.py#L164-L176)
Describe the solution you'd like
I understand it'll be difficult to enforce this feature for all modules. but once it's there it'll greatly improve usability. this feature request will probably require multiple PRs.
as a starting point, we could extract some examples from the existing unit tests.
Beta Was this translation helpful? Give feedback.
All reactions