Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CacheDataset for generative bundles. #544

Open
mingxin-zheng opened this issue Jan 8, 2024 · 0 comments · May be fixed by #541
Open

Use CacheDataset for generative bundles. #544

mingxin-zheng opened this issue Jan 8, 2024 · 0 comments · May be fixed by #541

Comments

@mingxin-zheng
Copy link
Contributor

Is your feature request related to a problem? Please describe.

For the diffusion bundle, monai.apps.DecathlonDataset is used by the generative bundles.

model-zoo/models/brats_mri_generative_diffusion/configs/train_autoencoder.json

Line 143 in f9334c1

"_target_": "monai.apps.DecathlonDataset",

model-zoo/models/brats_mri_axial_slices_generative_diffusion/configs/train_diffusion.json

Line 105 in f9334c1

"_target_": "monai.apps.DecathlonDataset",

It provides some convenience (auto-downloading datasets), but it makes overwriting the input datalist more difficult. Can we replace it with CacheDataset like the other bundles, which have more flexibility?

Describe the solution you'd like
Use CacheDataset for generative bundles.
@Can-Zhao Can-Zhao linked a pull request Jan 10, 2024 that will close this issue
Draft
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Diffusion bundle support monai service Can-Zhao/model-zoo
1 participant
@mingxin-zheng