Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

segresnet mlflow support #330

Merged
merged 7 commits into from
Nov 2, 2023
Merged

segresnet mlflow support #330

merged 7 commits into from
Nov 2, 2023

Conversation

myron
Copy link
Collaborator

@myron myron commented Oct 30, 2023

segresnet mlflow support

am added 2 commits October 29, 2023 22:34
Signed-off-by: am <am>
Signed-off-by: am <am>
@wyli wyli requested a review from Nic-Ma October 30, 2023 11:00
@Nic-Ma
Copy link
Contributor

Nic-Ma commented Nov 1, 2023

Hi @dongyang0122 , @drbeh ,

Could you please help review this PR? Ensure it can satisfy our requirements for the MLFlow URI.

Thanks in advance.

@dongyang0122
Copy link
Contributor

dongyang0122 commented Nov 1, 2023

Please update the PR as follows. Thanks!

  1. In algo.py, add these two lines.
  2. Create a new key in hyperparameter.yaml.
  3. Pass mlflow_tracking_uri into train.py.

Thanks.

Copy link
Contributor

@dongyang0122 dongyang0122 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comment.

@drbeh
Copy link
Member

drbeh commented Nov 2, 2023

@myron I would appreciate it if you can address the comment as soon as you can so we can use mlflow for segresnet in monai services. Thanks

@myron
Copy link
Collaborator Author

myron commented Nov 2, 2023

I've updated, please check

Copy link
Contributor

@dongyang0122 dongyang0122 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. Can you also update this file? Thanks.
https://github.com/myron/research-contributions/blob/updates/auto3dseg/metadata.json

@myron
Copy link
Collaborator Author

myron commented Nov 2, 2023

The changes look good to me. Can you also update this file? Thanks. https://github.com/myron/research-contributions/blob/updates/auto3dseg/metadata.json

Done.

@dongyang0122
Copy link
Contributor

The changes look good to me. Can you also update this file? Thanks. https://github.com/myron/research-contributions/blob/updates/auto3dseg/metadata.json

Done.

Thanks.

@drbeh drbeh merged commit d8ce454 into Project-MONAI:main Nov 2, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants