Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only set bank account reference matching probability when contact is not found in other ways #397

Open
jaapjansma opened this issue Sep 1, 2023 · 0 comments

Comments

@jaapjansma
Copy link
Collaborator

Context
CiviBanking now contains an option to set probability of the matched contact when the contact is found based on the bank account.

At Velt bank accounts are stored at different contacts (e.g. members of houdsholds, or because someone has used his private bank account for local chapter businesses. Meaning that bank account is also stored at the local chapter in CiviCRM.

Original issue

Some payments where automatically matched against wrong contacts because of this mix up of bank accounts.
This issue is solved by lowering the bank account reference matching probability setting (we have set it at 0.9)

New issue

Contacts found based on their sepa mandate or based on a number in the purpose field. Are also set to 0.9 probability because of the matching on bank account. However in those case we are sure because the Sepa Mandate Reference is leading.

Solution

Only set the probability for found contacts based on the bank account when they are not already found in different ways.

I will soon post a pull request fixing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant