Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImageView.createOpenSeadragonInstance should export fetched info.json metadata #1378

Closed
markmatney opened this issue Apr 7, 2017 · 1 comment
Labels
Mirador 2 Mirador 2

Comments

@markmatney
Copy link
Contributor

markmatney commented Apr 7, 2017

For context, please see this issue on the "dbmdz/mirador-plugins" repository.

Currently, if an implementer supplies physical dimension metadata according to schemes 3) or 4) (i.e., embedded in or referenced by info.json), that PhysicalRuler plugin breaks. The problem is that once the info.json metadata is fetched, it is thrown away when the callback returns. In order to support the physical ruler plugin move towards complete spec compliance, the metadata should be made available as a property on the ImageView object. So, inside that callback function, do something like

createOpenSeadragonInstance: function(imageUrl) {
    ...
    jQuery.getJSON(infoJsonUrl).done(function (infoJson, status, jqXHR) {
        ...
        _this.currentInfoJson = infoJson;
        ...
    });
}
@camillevilla
Copy link
Member

This ticket is being closed as part of the Mirador 3 issues review. We encourage all Mirador 2 implementers to try out Mirador 3 and leave feedback in new tickets.

@cbeer cbeer added the Mirador 2 Mirador 2 label Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mirador 2 Mirador 2
Projects
None yet
Development

No branches or pull requests

3 participants